-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(examples): add disperse #1414
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1414 +/- ##
=======================================
Coverage 56.26% 56.26%
=======================================
Files 425 425
Lines 64408 64408
=======================================
Hits 36237 36237
Misses 25349 25349
Partials 2822 2822
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This PR is currently blocked by the inability to write tests:
@moul @thehowl @deelawn @zivkovicmilos - how can we progress on making the testing experience better? |
I'm not sure what the exact problem is with using txtar for an e2e test. What kind of data do you need in the test? |
Two proposals:
|
One more thing: it seems to me that you don't actually need to create the accounts you claim you need to create (from the current state of the code). That is, unless they need to be able to move coins on their own, the accounts don't need to have a matching private key. You can just use disperse to send off tokens to some account strings you made up, and then check the txtar result of doing |
5c9075a
to
cc14f6d
Compare
Update on this: this has been sitting for a ton of time. Will get back to it soon hopefully, it's not a priority right now. |
This PR adds a gno version of the [disperse ethereum app](https://disperse.app/) to gno.land ! Another attempt was made in #1414 but we have decided to pick up from @leohhhn 's work with @lennyvong and made this PR, tested using txtar tests to avoid the situation described in #2595 There is also an older (but functional for the most part) version [deployed in test4](https://test4.gno.land/r/g1w62226g8hykfmtuasvz80rdf0jl6phgxsphh5v/testing/disperse2?help) with a linked [webapp](https://gno-disperse.netlify.app/) <img width="649" alt="image" src="https://github.com/user-attachments/assets/ad26a1a9-0447-4333-858a-253441c457ba"> <details><summary>Contributors' checklist...</summary> - [X] Added new tests, or not needed, or not feasible - [X] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory - [X] Updated the official documentation or not needed - [X] No breaking changes were made, or a `BREAKING CHANGE: xxx` message was included in the description - [X] Added references to related issues and PRs - [X] Provided any useful hints for running manual tests - [ ] Added new benchmarks to [generated graphs](https://gnoland.github.io/benchmarks), if any. More info [here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md). </details> --------- Co-authored-by: leohhhn <hudakleon@gmail.com> Co-authored-by: Leon Hudak <33522493+leohhhn@users.noreply.github.com> Co-authored-by: lennyvongphouthone <lenny.vongphouthone@epitech.eu> Co-authored-by: Guilhem Fanton <8671905+gfanton@users.noreply.github.com>
Description
This PR adds a port of the Disperse.app smart contract on EVM. It helps showcase how sending GNOT to and from a realm works.
This PR is part of the Dogfooding initiative. Here is the linking comment.
Contributors' checklist...
BREAKING CHANGE: xxx
message was included in the description