Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(grc20,foo20): lazily resolve username in grc20 (and foo20) #145

Merged
merged 6 commits into from
May 9, 2022

Conversation

moul
Copy link
Member

@moul moul commented Apr 28, 2022

The magic of Gno!

Few lines added, and tada, the whole contract supports using registered usernames for both the contract arguments and the Render() path parts.

F4A438BD-86C7-4505-A8D8-D026D024EB46

Closes #166

@moul moul changed the title chore(grc20): lazily resolve username chore(grc20): lazily resolve username in grc20 (and foo20) Apr 28, 2022
@jaekwon
Copy link
Contributor

jaekwon commented May 4, 2022

How about this? https://github.com/gnolang/gno/pull/166/files

@moul
Copy link
Member Author

moul commented May 4, 2022

yep, nice, I'll go with it and we can start using "@" prefix everywhere for usernames 👍

will update the PR soon :)

moul added 3 commits May 6, 2022 16:53
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
…20 and foo20

Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
@moul moul marked this pull request as draft May 6, 2022 16:54
jaekwon and others added 3 commits May 6, 2022 16:56
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
@moul moul marked this pull request as ready for review May 6, 2022 17:36
@moul
Copy link
Member Author

moul commented May 6, 2022

@jaekwon ready for review

@moul moul requested a review from jaekwon May 6, 2022 17:36
Copy link
Contributor

@jaekwon jaekwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@moul moul changed the title chore(grc20): lazily resolve username in grc20 (and foo20) feat(grc20): lazily resolve username in grc20 (and foo20) May 9, 2022
@moul moul changed the title feat(grc20): lazily resolve username in grc20 (and foo20) feat(grc20,foo20): lazily resolve username in grc20 (and foo20) May 9, 2022
@moul moul merged commit 081442c into gnolang:master May 9, 2022
@moul moul deleted the dev/moul/grc20-users branch July 5, 2022 09:16
@moul moul added this to the 🏗1️⃣ test1.gno.land milestone Oct 20, 2022
@moul moul self-assigned this Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants