feat: new txtar command adduser
#1471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
📦 ⛰️ gno.land
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1471 +/- ##
==========================================
- Coverage 55.87% 55.65% -0.23%
==========================================
Files 430 431 +1
Lines 65618 67201 +1583
==========================================
+ Hits 36667 37402 +735
- Misses 26083 26866 +783
- Partials 2868 2933 +65
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Related with #1269 |
moul
reviewed
Dec 20, 2023
moul
reviewed
Dec 20, 2023
moul
approved these changes
Dec 20, 2023
gfanton
reviewed
Dec 20, 2023
gfanton
reviewed
Dec 20, 2023
There was a problem hiding this comment.
Can you provide more details or/and example regarding the use of the sleep command? As mentioned in #1471 (comment) , I'm a bit apprehensive about introducing this command.
deelawn
changed the title
adduser and sleepadduser
gfanton
approved these changes
Dec 21, 2023
zivkovicmilos
requested changes
Dec 21, 2023
harry-hov
approved these changes
Dec 21, 2023
Co-authored-by: Hariom Verma <hariom18599@gmail.com>
…o feat/txtar-sleep-adduser
zivkovicmilos
approved these changes
Dec 22, 2023
There was a problem hiding this comment.
Thank you for taking a look at the comments 🙏
I've opened up an issue to discuss how we orchestrate txtar nodes, to avoid further blocking this PR:
#1484 (comment)
gfanton
pushed a commit
to moul/gno
that referenced
this pull request
Jan 18, 2024
<!-- please provide a detailed description of the changes made in this pull request. --> As I've started to think about creating txtar tests for contracts with logic depending on contract calls from multiple users and durations since previous contract calls, the addition of the `adduser` command seems to be necessary. <details><summary>Contributors' checklist...</summary> - [x] Added new tests, or not needed, or not feasible - [x] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory - [x] Updated the official documentation or not needed - [x] No breaking changes were made, or a `BREAKING CHANGE: xxx` message was included in the description - [ ] Added references to related issues and PRs - [ ] Provided any useful hints for running manual tests - [ ] Added new benchmarks to [generated graphs](https://gnoland.github.io/benchmarks), if any. More info [here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md). </details> --------- Co-authored-by: Hariom Verma <hariom18599@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I've started to think about creating txtar tests for contracts with logic depending on contract calls from multiple users and durations since previous contract calls, the addition of the
addusercommand seems to be necessary.Contributors' checklist...
BREAKING CHANGE: xxxmessage was included in the description