Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make gnokey consistent with the changes applied to gnokeykc #1554

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

thehowl
Copy link
Member

@thehowl thehowl commented Jan 18, 2024

See #1531

@thehowl thehowl self-assigned this Jan 18, 2024
@thehowl thehowl requested a review from moul as a code owner January 18, 2024 17:17
@github-actions github-actions bot added the 📦 ⛰️ gno.land Issues or PRs gno.land package related label Jan 18, 2024
Copy link

codecov bot commented Jan 18, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (17b1303) 55.73% compared to head (a5c4409) 55.73%.
Report is 1 commits behind head on master.

Files Patch % Lines
gno.land/cmd/gnokey/main.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1554   +/-   ##
=======================================
  Coverage   55.73%   55.73%           
=======================================
  Files         435      435           
  Lines       65933    65931    -2     
=======================================
  Hits        36748    36748           
+ Misses      26303    26301    -2     
  Partials     2882     2882           
Flag Coverage Δ
go-1.21.x ∅ <ø> (∅)
misc ∅ <ø> (∅)
misc-_test.genstd ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thehowl thehowl merged commit 7888dca into master Jan 23, 2024
182 of 183 checks passed
@thehowl thehowl deleted the dev/morgan/consistency-gnokey branch January 23, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 ⛰️ gno.land Issues or PRs gno.land package related
Projects
Status: Done
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants