refactor: compile all regexes at init #1592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thehowl
requested review from
harry-hov,
jaekwon,
piux2,
moul and
zivkovicmilos
as code owners
github-actions
bot
added
📦 🤖 gnovm
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1592 +/- ##
==========================================
- Coverage 55.80% 55.79% -0.01%
==========================================
Files 436 436
Lines 66168 66156 -12
==========================================
- Hits 36922 36913 -9
+ Misses 26356 26355 -1
+ Partials 2890 2888 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ajnavarro
approved these changes
Jan 29, 2024
leohhhn
pushed a commit
to leohhhn/gno
that referenced
this pull request
Feb 2, 2024
This PR changes all regexes (except for some in test files) in the code to make them compile at init. This, aside from giving a slight performance optimisation by skipping the compile stage on execution, allows also to ensure that the regexes themselves are correct by panicking at program start-up if they are not. (before this PR, in almost every instance where we used `regexp.MatchString` or similar, we did not check the error).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes all regexes (except for some in test files) in the code to make them compile at init.
This, aside from giving a slight performance optimisation by skipping the compile stage on execution, allows also to ensure that the regexes themselves are correct by panicking at program start-up if they are not. (before this PR, in almost every instance where we used
regexp.MatchStringor similar, we did not check the error).