fix: []byte("xxx") should not be treated as const #1597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ltzmaxwell
requested review from
jaekwon,
piux2,
thehowl and
moul
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1597 +/- ##
==========================================
+ Coverage 55.80% 56.17% +0.37%
==========================================
Files 436 436
Lines 66168 66549 +381
==========================================
+ Hits 36922 37382 +460
+ Misses 26356 26247 -109
- Partials 2890 2920 +30
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
deelawn
approved these changes
Feb 14, 2024
moul
approved these changes
Feb 14, 2024
thehowl
approved these changes
Feb 14, 2024
leohhhn
pushed a commit
to leohhhn/gno
that referenced
this pull request
Feb 29, 2024
…lang#1597) this is a fix to gnolang#1570 . The underlying issue in gnolang#1570 stems from how []byte("xxx") is handled: it's treated as a constant, yet its value can still be altered. This mutability leads to unintended persistence of its state across loop iterations. The proposed resolution involves modifying the preprocessing stage to avoid converting an untyped string directly into a []byte type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a fix to #1570 .
The underlying issue in #1570 stems from how []byte("xxx") is handled: it's treated as a constant, yet its value can still be altered. This mutability leads to unintended persistence of its state across loop iterations.
The proposed resolution involves modifying the preprocessing stage to avoid converting an untyped string directly into a []byte type.