Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: gnodev reference #1599

Merged
merged 13 commits into from
Jan 31, 2024
Merged

docs: gnodev reference #1599

merged 13 commits into from
Jan 31, 2024

Conversation

leohhhn
Copy link
Contributor

@leohhhn leohhhn commented Jan 29, 2024

Description

This PR adds the gnodev reference into the docs under Gno Tooling, and also updates the current gnodev readme in the contribs folder.

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

@leohhhn leohhhn marked this pull request as ready for review January 29, 2024 19:33
@leohhhn leohhhn requested review from gfanton and a team as code owners January 29, 2024 19:33
Co-authored-by: jon roethke <waymobetta@users.noreply.github.com>
Co-authored-by: jon roethke <waymobetta@users.noreply.github.com>
Co-authored-by: jon roethke <waymobetta@users.noreply.github.com>
@waymobetta waymobetta self-requested a review January 29, 2024 20:57
@leohhhn leohhhn requested a review from a team as a code owner January 29, 2024 20:58
@leohhhn leohhhn merged commit 8379c0d into gnolang:master Jan 31, 2024
8 checks passed
@leohhhn leohhhn deleted the docs/gnodev branch January 31, 2024 09:11
@thehowl
Copy link
Member

thehowl commented Jan 31, 2024

@leohhhn a small suggestion, imo this PR looks good, but I think it's better if we have a minimal description on contribs/gnodev/README.md and refer to the docs as the official source of truth :)

leohhhn added a commit to leohhhn/gno that referenced this pull request Feb 2, 2024
## Description

This PR adds the `gnodev` reference into the docs under `Gno Tooling`,
and also updates the current `gnodev` readme in the `contribs` folder.

<details><summary>Contributors' checklist...</summary>

- [ ] Added new tests, or not needed, or not feasible
- [ ] Provided an example (e.g. screenshot) to aid review or the PR is
self-explanatory
- [ ] Updated the official documentation or not needed
- [ ] No breaking changes were made, or a `BREAKING CHANGE: xxx` message
was included in the description
- [ ] Added references to related issues and PRs
- [ ] Provided any useful hints for running manual tests
- [ ] Added new benchmarks to [generated
graphs](https://gnoland.github.io/benchmarks), if any. More info
[here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md).
</details>

---------

Co-authored-by: jon roethke <waymobetta@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Status: Done
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants