Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vm): add CommentGroup and Comment attributes #1658

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

gfanton
Copy link
Member

@gfanton gfanton commented Feb 15, 2024

Add CommentGroup and Comment attribute support to the VM. The main reason behind this is to have the ability to handle special directives such as // nolint without having to re-parse every file.
I've left some XXX comments in places where I'm unsure of what to do.

partially address: #1042
related to: #1450

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
@gfanton gfanton self-assigned this Feb 15, 2024
@github-actions github-actions bot added the 📦 🤖 gnovm Issues or PRs gnovm related label Feb 15, 2024
Copy link

codecov bot commented Feb 15, 2024

Codecov Report

Attention: 71 lines in your changes are missing coverage. Please review.

Comparison is base (0cce745) 56.17% compared to head (58280a9) 56.23%.
Report is 1 commits behind head on master.

Files Patch % Lines
gnovm/pkg/gnolang/nodes.go 0.00% 54 Missing ⚠️
gnovm/pkg/gnolang/nodes_copy.go 0.00% 10 Missing ⚠️
gnovm/pkg/gnolang/nodes_string.go 0.00% 4 Missing ⚠️
gnovm/pkg/gnolang/go2gno.go 94.91% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1658      +/-   ##
==========================================
+ Coverage   56.17%   56.23%   +0.05%     
==========================================
  Files         439      439              
  Lines       66242    66723     +481     
==========================================
+ Hits        37209    37519     +310     
- Misses      26143    26299     +156     
- Partials     2890     2905      +15     
Flag Coverage Δ
go-1.21.x ∅ <ø> (∅)
misc ∅ <ø> (∅)
misc-_test.genstd ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
@0xtekgrinder
Copy link

When this is merged I could help setting up the base for the linter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 🤖 gnovm Issues or PRs gnovm related
Projects
Status: No status
Status: No status
Status: Triage
Development

Successfully merging this pull request may close these issues.

2 participants