test: improve gnovm/pkg/gnolang.TestPrecompile()
#1659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test actually only tested the private `precompileAST` function, not the public `Precompile` function. The change makes it call the public function and adds some more cases described in comments like: - unknow-realm (no error) - syntax error - blacklist (was already done) - multiple files (not possible, `Precompile` is single file only) Also used multiple-line string for file and expected content, for better readability. Relates to gnolang#1636
tbruyelle
requested review from
jaekwon,
piux2,
thehowl and
moul
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1659 +/- ##
==========================================
- Coverage 56.17% 55.12% -1.05%
==========================================
Files 439 447 +8
Lines 66247 67917 +1670
==========================================
+ Hits 37214 37439 +225
- Misses 26143 27563 +1420
- Partials 2890 2915 +25
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
thehowl
approved these changes
Feb 15, 2024
harry-hov
approved these changes
Feb 15, 2024
leohhhn
pushed a commit
to leohhhn/gno
that referenced
this pull request
Feb 29, 2024
This test actually only tested the private `precompileAST()` function, not the public `Precompile()` function. The change makes it call the public function and adds some more cases described in comments like: - unknow-realm (no error) - syntax error - blacklist (was already done) - multiple files (not possible, `Precompile()` is single file only) Also used multiple-line string for file and expected content, for better readability. Relates to gnolang#1636 The test can be run with ``` go test ./gnovm/pkg/gnolang/ -v -run Precompile ``` <!-- please provide a detailed description of the changes made in this pull request. --> <details><summary>Contributors' checklist...</summary> - [x] Added new tests, or not needed, or not feasible - [ ] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory - [ ] Updated the official documentation or not needed - [x] No breaking changes were made, or a `BREAKING CHANGE: xxx` message was included in the description - [ ] Added references to related issues and PRs - [x] Provided any useful hints for running manual tests - [ ] Added new benchmarks to [generated graphs](https://gnoland.github.io/benchmarks), if any. More info [here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md). </details>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test actually only tested the private
precompileAST()function, not the publicPrecompile()function.The change makes it call the public function and adds some more cases described in comments like:
Precompile()is single file only)Also used multiple-line string for file and expected content, for better readability.
Relates to #1636
The test can be run with
Contributors' checklist...
BREAKING CHANGE: xxxmessage was included in the description