fix: correctly validate package/realm path #1813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1813 +/- ##
=======================================
Coverage 47.78% 47.78%
=======================================
Files 393 393
Lines 61660 61660
=======================================
Hits 29465 29465
Misses 29723 29723
Partials 2472 2472 ☔ View full report in Codecov by Sentry. |
harry-hov
requested review from
jaekwon,
piux2,
moul and
zivkovicmilos
as code owners
petar-dambovaliev
approved these changes
Mar 23, 2024
leohhhn
approved these changes
Mar 23, 2024
|
Reviewing now, please don't merge yet |
zivkovicmilos
requested changes
Mar 27, 2024
9 tasks
harry-hov
force-pushed
the
fix/rePkgOrRlmPath
branch
from
8dfe7e2
to
0d5de3d
Compare
harry-hov
force-pushed
the
fix/rePkgOrRlmPath
branch
from
0d5de3d
to
61afe4a
Compare
|
@zivkovicmilos Sorry for force pushing the branch. This solution is not related to the previous one. Please take another look. Thanks for the review. |
harry-hov
added
breaking change
zivkovicmilos
approved these changes
Apr 17, 2024
omarsy
pushed a commit
to TERITORI/gno
that referenced
this pull request
Apr 21, 2024
The regex pattern used for package/realm path validation is incorrect. Currently, it allows paths with special characters and empty path parts, Fixed it. BREAKING CHANGE: - Special characters are disallowed - Cannot have trailing slash(s) - Cannot have empty path part - Cannot have solely `_`[underscore(s)] in path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The regex pattern used for package/realm path validation is incorrect. Currently, it allows paths with special characters and empty path parts, commit f98e509 demonstrates that.
Subsequent commits fixes it.
BREAKING CHANGE:
_[underscore(s)] in pathContributors' checklist...
BREAKING CHANGE: xxxmessage was included in the description