feat: support crypto/ed25519.Verify #1863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omarsy
force-pushed
the
feat/add-ed25519
branch
from
786e2ea
to
f474172
Compare
omarsy
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1863 +/- ##
==========================================
- Coverage 47.77% 45.11% -2.67%
==========================================
Files 393 464 +71
Lines 61630 68039 +6409
==========================================
+ Hits 29443 30693 +1250
- Misses 29717 34773 +5056
- Partials 2470 2573 +103 ☔ View full report in Codecov by Sentry. |
n0izn0iz
force-pushed
the
feat/add-ed25519
branch
from
f474172
to
281926f
Compare
|
Thank you for the contribution! Sorry for the delay, I'll try to take a look in the next few days! |
omarsy
force-pushed
the
feat/add-ed25519
branch
from
a6931f8
to
d8e189c
Compare
github-actions
bot
added
📦 🌐 tendermint v2
omarsy
force-pushed
the
feat/add-ed25519
branch
2 times, most recently
from
d8e189c
to
eb77b4a
Compare
Co-authored-by: Miguel Victoria Villaquiran <Villaquiranm@users.noreply.github.com>
omarsy
force-pushed
the
feat/add-ed25519
branch
from
eb77b4a
to
16cd8b1
Compare
thehowl
reviewed
Apr 17, 2024
thehowl
approved these changes
Apr 17, 2024
Signed-off-by: Norman Meier <norman@samourai.coop>
omarsy
added a commit
to TERITORI/gno
that referenced
this pull request
Apr 21, 2024
Support crypto/ed25519 on GnoVM <details><summary>Contributors' checklist...</summary> - [x] Added new tests, or not needed, or not feasible - [x] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory - [x] Updated the official documentation or not needed - [ ] No breaking changes were made, or a `BREAKING CHANGE: xxx` message was included in the description - [ ] Added references to related issues and PRs - [ ] Provided any useful hints for running manual tests - [ ] Added new benchmarks to [generated graphs](https://gnoland.github.io/benchmarks), if any. More info [here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md). </details> --------- Signed-off-by: Norman Meier <norman@samourai.coop> Co-authored-by: Miguel Victoria Villaquiran <Villaquiranm@users.noreply.github.com> Co-authored-by: Norman Meier <norman@samourai.coop> Co-authored-by: n0izn0iz <n0izn0iz@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support crypto/ed25519 on GnoVM
Contributors' checklist...
BREAKING CHANGE: xxxmessage was included in the description