fix(gnovm): correct comparison between different types #1890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…terface_comparison
ltzmaxwell
commented
Jul 30, 2024
ltzmaxwell
changed the title
|
Hi @thehowl , this one is good for review. 🙏 |
thehowl
approved these changes
Jul 30, 2024
ltzmaxwell
commented
Jul 31, 2024
deelawn
approved these changes
Aug 1, 2024
Co-authored-by: deelawn <dboltz03@gmail.com>
Co-authored-by: deelawn <dboltz03@gmail.com>
…no into fix/maxwell/type_comparison
piux2
reviewed
Aug 14, 2024
piux2
approved these changes
Aug 14, 2024
MikaelVallenet
pushed a commit
to MikaelVallenet/gno
that referenced
this pull request
Aug 17, 2024
Fixes gnolang#1376, fixes gnolang#2386. --------- Co-authored-by: deelawn <dboltz03@gmail.com>
This was referenced Aug 20, 2024
7 tasks
ltzmaxwell
added a commit
that referenced
this pull request
Sep 11, 2024
This closes #2719. copy from #2719: >#1890 introduced strict type comparison, which is the correct approach but overlooked the problem mentioned above, resulting in the comparison between bool and untyped bool. I will provide a fix soon. <!-- please provide a detailed description of the changes made in this pull request. --> <details><summary>Contributors' checklist...</summary> - [ ] Added new tests, or not needed, or not feasible - [ ] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory - [ ] Updated the official documentation or not needed - [ ] No breaking changes were made, or a `BREAKING CHANGE: xxx` message was included in the description - [ ] Added references to related issues and PRs - [ ] Provided any useful hints for running manual tests - [ ] Added new benchmarks to [generated graphs](https://gnoland.github.io/benchmarks), if any. More info [here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md). </details>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1376, fixes #2386.