Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: create codeql.yml #1915

Merged
merged 3 commits into from
Apr 17, 2024
Merged

ci: create codeql.yml #1915

merged 3 commits into from
Apr 17, 2024

Conversation

kristovatlas
Copy link
Contributor

@kristovatlas kristovatlas commented Apr 11, 2024

Enabling CodeQL code security scanning support for the gno repo.

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

Copy link

codecov bot commented Apr 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.26%. Comparing base (ca6566f) to head (06519c8).
Report is 12 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1915      +/-   ##
==========================================
- Coverage   47.79%   45.26%   -2.53%     
==========================================
  Files         393      464      +71     
  Lines       61654    68264    +6610     
==========================================
+ Hits        29465    30898    +1433     
- Misses      29717    34783    +5066     
- Partials     2472     2583     +111     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@zivkovicmilos zivkovicmilos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 💯

.github/workflows/codeql.yml Outdated Show resolved Hide resolved
.github/workflows/codeql.yml Outdated Show resolved Hide resolved
@zivkovicmilos zivkovicmilos changed the title Create codeql.yml feat: create codeql.yml Apr 11, 2024
Co-authored-by: Hariom Verma <hariom.verma@tendermint.com>
@thehowl thehowl changed the title feat: create codeql.yml ci: create codeql.yml Apr 15, 2024
comment from @thehowl: cpp scanning Seems like it's causing the check to fail. I suspect because of the libsecp256k1 source, which for reasons unknown to me is in the repo.
@zivkovicmilos zivkovicmilos merged commit 3297d0c into master Apr 17, 2024
189 checks passed
@zivkovicmilos zivkovicmilos deleted the kristovatlas-patch-1 branch April 17, 2024 07:58
n0izn0iz pushed a commit to TERITORI/gno that referenced this pull request Apr 17, 2024
<!-- please provide a detailed description of the changes made in this
pull request. -->

Enabling CodeQL code security scanning support for the gno repo.

<details><summary>Contributors' checklist...</summary>

- [ ] Added new tests, or not needed, or not feasible
- [x] Provided an example (e.g. screenshot) to aid review or the PR is
self-explanatory
- [x] Updated the official documentation or not needed
- [x] No breaking changes were made, or a `BREAKING CHANGE: xxx` message
was included in the description
- [x] Added references to related issues and PRs
- [x] Provided any useful hints for running manual tests
- [x] Added new benchmarks to [generated
graphs](https://gnoland.github.io/benchmarks), if any. More info
[here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md).
</details>

---------

Co-authored-by: Hariom Verma <hariom.verma@tendermint.com>
omarsy pushed a commit to TERITORI/gno that referenced this pull request Apr 21, 2024
<!-- please provide a detailed description of the changes made in this
pull request. -->

Enabling CodeQL code security scanning support for the gno repo.

<details><summary>Contributors' checklist...</summary>

- [ ] Added new tests, or not needed, or not feasible
- [x] Provided an example (e.g. screenshot) to aid review or the PR is
self-explanatory
- [x] Updated the official documentation or not needed
- [x] No breaking changes were made, or a `BREAKING CHANGE: xxx` message
was included in the description
- [x] Added references to related issues and PRs
- [x] Provided any useful hints for running manual tests
- [x] Added new benchmarks to [generated
graphs](https://gnoland.github.io/benchmarks), if any. More info
[here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md).
</details>

---------

Co-authored-by: Hariom Verma <hariom.verma@tendermint.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants