Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docker): fix docker action by adding build target #1920

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

gfanton
Copy link
Member

@gfanton gfanton commented Apr 11, 2024

In the previous PR #1912, the target was not specified, causing slim images to build the first layer of the Dockerfile. This PR updates the docker action to correctly pass the target argument.

Signed-off-by: gfanton 8671905+gfanton@users.noreply.github.com

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
@gfanton gfanton self-assigned this Apr 11, 2024
@gfanton gfanton requested review from moul and a team as code owners April 11, 2024 20:51
@gfanton gfanton changed the title fix(docker): fix docker build target fix(docker): fix docker action by adding build target Apr 11, 2024
Copy link

codecov bot commented Apr 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.79%. Comparing base (f962c71) to head (7f7f516).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1920   +/-   ##
=======================================
  Coverage   47.79%   47.79%           
=======================================
  Files         393      393           
  Lines       61643    61643           
=======================================
  Hits        29463    29463           
  Misses      29708    29708           
  Partials     2472     2472           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zivkovicmilos zivkovicmilos merged commit 35a29a5 into gnolang:master Apr 11, 2024
186 of 189 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants