-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: move genesis
to gnoland genesis
#1954
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1954 +/- ##
==========================================
+ Coverage 45.17% 48.25% +3.08%
==========================================
Files 465 408 -57
Lines 68081 62338 -5743
==========================================
- Hits 30753 30081 -672
+ Misses 34747 29749 -4998
+ Partials 2581 2508 -73 ☔ View full report in Codecov by Sentry. |
genesis
to gnoland genesis
genesis
to gnoland genesis
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we move all the files for the genesis commands to have the prefix genesis_
? (so genesis_balances.go
, etc.)
I would also personally prefer if we didn't have as many files in the directory; ie. group genesis_balances
subcommands and genesis_txs
subcommands together; this can be tackled in another PR, though.
🤦♂️ I completely forgot to do this as a final step 🙃 Fixed: |
## Description Closes gnolang#1953 This PR moves the `genesis` command suite to be a subcommand of `gnoland`, making it callable with `gnoland genesis`. <details><summary>Contributors' checklist...</summary> - [x] Added new tests, or not needed, or not feasible - [x] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory - [x] Updated the official documentation or not needed - [x] No breaking changes were made, or a `BREAKING CHANGE: xxx` message was included in the description - [x] Added references to related issues and PRs - [ ] Provided any useful hints for running manual tests - [ ] Added new benchmarks to [generated graphs](https://gnoland.github.io/benchmarks), if any. More info [here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md). </details>
Description
Closes #1953
This PR moves the
genesis
command suite to be a subcommand ofgnoland
, making it callable withgnoland genesis
.Contributors' checklist...
BREAKING CHANGE: xxx
message was included in the description