-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement txs generate
and txs clear
command
#1988
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1988 +/- ##
==========================================
- Coverage 54.64% 48.40% -6.25%
==========================================
Files 578 411 -167
Lines 77870 62408 -15462
==========================================
- Hits 42551 30207 -12344
+ Misses 32149 29684 -2465
+ Partials 3170 2517 -653
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this PR is overcomplicating already existing functionality (genesis txs
). The subcommands are practically copy pasted from the mentioned command suite.
add
- what do we accomplish with this, that we don't already withgenesis txs add
?clear
- this would've been a good addition togenesis txs
list
- this would've been a good addition togenesis txs
get
- I'm not sure when anybody would use thisdel
- what do we accomplish with this, that we don't already withgenesis txs remove
?
What I'm trying to say is -- we already had this functionality in some form or another, so there is no need to define an entirely new command suite for it (that we have to maintain). Please consider refactoring this PR to improve the existing genesis txs
command suite with additional / more richer functionality 🙏
genesis packages
command suitetxs generate
and txs clear
command
@zivkovicmilos I have applied the changes as requested Added these subcommands to
|
Closing in favor of #2327 |
## Description This PR introduces the ability to specify a package directory that will recursively be added (deployed) to the `genesis.json`, utilizing the existing `gnoland genesis txs add` command. It also separates out the logic from `gnoland genesis txs add` into: - `gnoland genesis txs add sheets` for individual tx sheet files (ex. from tx-archive output) - `gnoland genesis txs add packages` for recursively adding packages (ex. `examples`) ![sample](https://github.com/gnolang/gno/assets/16712663/e88b363f-2911-454e-8002-46ee4cbecde6) Related: - #1952 - #1988 <details><summary>Contributors' checklist...</summary> - [x] Added new tests, or not needed, or not feasible - [x] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory - [x] Updated the official documentation or not needed - [x] No breaking changes were made, or a `BREAKING CHANGE: xxx` message was included in the description - [x] Added references to related issues and PRs - [ ] Provided any useful hints for running manual tests - [ ] Added new benchmarks to [generated graphs](https://gnoland.github.io/benchmarks), if any. More info [here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md). </details> --------- Co-authored-by: Guilhem Fanton <8671905+gfanton@users.noreply.github.com>
Adds
generate
andclear
tognoland genesis txs
commandWith these changes, initial set of packages can be added to
genesis.json
usinggnoland genesis txs generate /examples
. Next step is to remove genesis generation logic fromgnoland start
; so thatgnoland start
can only focus on starting the node properly.Related: #1952