-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add p/uuid #2076
base: master
Are you sure you want to change the base?
feat: add p/uuid #2076
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2076 +/- ##
==========================================
- Coverage 63.32% 63.10% -0.22%
==========================================
Files 548 548
Lines 78511 81134 +2623
==========================================
+ Hits 49719 51203 +1484
- Misses 25438 26511 +1073
- Partials 3354 3420 +66
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There is no other way to guarantee atomicity besides using time in environments where atomic is not supported. If we consider it further, it seems possible to generate a random value (using |
Thanks for your explanation. I will check the progress of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is super cool, I can already see myself using it :)
I've left a few comments, otherwise it looks good 💯
Co-authored-by: Morgan <git@howl.moe>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems not "gno-ified" enough :)
can you also provide some examples, like a screenshot or something so that we can see various generated output examples just by reviewing the PR, please?
Output this my last commit 485ce8d: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finish corrective review
Hey @DIGIX666, can you please update this branch with |
I suggest adding a
UUID
package because I think it could be useful to have it available. I think it can further facilitate traceability and compatibility between different systems and apps as they would have a common standard for identifying entities.To improve
UUID
generation, I wanted to add a resolver likeSnowflake
, but from what I've searched,sync/atomic
is not supported on Gno. Is there another similar package that I might have missed ?