fix(gnovm/store): copy store caches #2105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thehowl
requested review from
jaekwon,
moul,
piux2,
deelawn,
zivkovicmilos and
a team
as code owners
github-actions
bot
added
📦 🤖 gnovm
thehowl
changed the title
zivkovicmilos
approved these changes
May 14, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2105 +/- ##
=======================================
Coverage 47.00% 47.00%
=======================================
Files 578 578
Lines 77581 77582 +1
=======================================
+ Hits 36467 36468 +1
Misses 38076 38076
Partials 3038 3038
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jefft0
pushed a commit
to jefft0/gno
that referenced
this pull request
May 15, 2024
Hotfix for the failing CI on master. Changes `cacheTypes`, `cacheNodes` and `cacheNativeTypes` to be copies when forking the store, so that the forked store doesn't modify its parent. cc @zivkovicmilos
thehowl
pushed a commit
that referenced
this pull request
May 15, 2024
leohhhn
pushed a commit
to leohhhn/gno
that referenced
this pull request
May 21, 2024
This PR adds a simple regression test for a bug that was introduced in gnolang#1702 and fixed in gnolang#2105 . Signed-off-by: Jeff Thompson <jeff@thefirst.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hotfix for the failing CI on master. Changes
cacheTypes,cacheNodesandcacheNativeTypesto be copies when forking the store, so that the forked store doesn't modify its parent.cc @zivkovicmilos