-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: test gno.land when changing gnovm and tm2 #2215
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2215 +/- ##
==========================================
- Coverage 54.63% 54.63% -0.01%
==========================================
Files 581 581
Lines 77967 78077 +110
==========================================
+ Hits 42601 42661 +60
- Misses 32186 32235 +49
- Partials 3180 3181 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is going to mess up code coverage...
If we need some kind of integration tests, we should add them inside gno.land folder.
Wdym? How could this mess up the coverage? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nevermind, I thought that codecov will be confused if we added the same coverage for several tags, but it might not be the case.
I'd like if we had good tests and decoupled components that could make this unnecessary. However I believe it's still the case that modifying something in tm2 and gnovm can create issues on gno.land without showing up on the CI, seeing as it is the component that strictly depends on both tm2 and gnovm.