Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(make): re-enable package testing #2269

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

ltzmaxwell
Copy link
Contributor

The package tests for gnovm were missing; they have been added back.

@github-actions github-actions bot added the 📦 🤖 gnovm Issues or PRs gnovm related label Jun 3, 2024
@ltzmaxwell ltzmaxwell changed the title fix(gnovm): Re-enable package testing fix(gnovm): re-enable package testing Jun 3, 2024
Copy link

codecov bot commented Jun 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.62%. Comparing base (195de0a) to head (ed37454).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2269   +/-   ##
=======================================
  Coverage   54.62%   54.62%           
=======================================
  Files         578      578           
  Lines       77870    77870           
=======================================
  Hits        42536    42536           
  Misses      32162    32162           
  Partials     3172     3172           
Flag Coverage Δ
gnovm 59.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@deelawn deelawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch

@thehowl thehowl changed the title fix(gnovm): re-enable package testing fix(make): re-enable package testing Jun 3, 2024
@thehowl thehowl merged commit e8af2a4 into gnolang:master Jun 3, 2024
48 checks passed
omarsy pushed a commit to TERITORI/gno that referenced this pull request Jun 3, 2024
The package tests for gnovm were missing; they have been added back.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 🤖 gnovm Issues or PRs gnovm related
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants