chore: make contribs/ Makefile dynamic #2318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: moul <94029+moul@users.noreply.github.com>
moul
requested review from
thehowl and
ltzmaxwell
and removed request for
a team
Signed-off-by: moul <94029+moul@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2318 +/- ##
==========================================
- Coverage 54.71% 54.71% -0.01%
==========================================
Files 590 590
Lines 79036 79036
==========================================
- Hits 43248 43246 -2
- Misses 32540 32541 +1
- Partials 3248 3249 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This was referenced Jun 10, 2024
Signed-off-by: moul <94029+moul@users.noreply.github.com>
Signed-off-by: moul <94029+moul@users.noreply.github.com>
ltzmaxwell
approved these changes
Jun 17, 2024
gfanton
pushed a commit
to gfanton/gno
that referenced
this pull request
Jul 23, 2024
Continues gnolang#2013 > People should focus on their contributions in the `contribs/MYFOLDER` without updating a shared `Makefile` + `.github/contribs/*.yml`. The CI part has been completed in gnolang#2040. This pull request handles the Makefile portion. --------- Signed-off-by: moul <94029+moul@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continues #2013
The CI part has been completed in #2040.
This pull request handles the Makefile portion.