-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(examples): add r/morgan/{home,guestbook}
#2345
Conversation
Leon pointed out that we have r/demo/userbook, which achieves something similar. We can consider whether to keep both, or just one or the other. I see two advantages with this realm: using avl.Trees + pagination, and providing users with a way to actually "write something" (with the consequence of moderation -- hence why there is an admin function the remove a user's post; though obviously with the faucet working anyone can just have another account). cc @moul |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2345 +/- ##
==========================================
+ Coverage 60.44% 60.45% +0.01%
==========================================
Files 563 563
Lines 75157 75159 +2
==========================================
+ Hits 45426 45436 +10
+ Misses 26341 26333 -8
Partials 3390 3390
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but we should consider renaming this example to avoid conflicts with other guestbook implementations.
r/morgan/{home,guestbook}
Moved it to r/morgan/guestbook and added a small home realm. It seems appropriate for now. |
I wanted a simple realm that allows any user to interact with it and see something happen. This is a guestbook realm; it allows anyone to leave a small message, which will be associated with their address.
It also is a nice showcase of how to effectively do pagination with AVL trees. I don't think we have many such examples so far.