Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(examples): add r/morgan/{home,guestbook} #2345

Merged
merged 7 commits into from
Sep 12, 2024
Merged

Conversation

thehowl
Copy link
Member

@thehowl thehowl commented Jun 12, 2024

I wanted a simple realm that allows any user to interact with it and see something happen. This is a guestbook realm; it allows anyone to leave a small message, which will be associated with their address.

It also is a nice showcase of how to effectively do pagination with AVL trees. I don't think we have many such examples so far.

@thehowl thehowl self-assigned this Jun 12, 2024
@thehowl thehowl requested review from a team as code owners June 12, 2024 18:43
@thehowl thehowl requested review from ajnavarro and zivkovicmilos and removed request for a team June 12, 2024 18:43
@github-actions github-actions bot added the 🧾 package/realm Tag used for new Realms or Packages. label Jun 12, 2024
@thehowl
Copy link
Member Author

thehowl commented Jun 13, 2024

Leon pointed out that we have r/demo/userbook, which achieves something similar. We can consider whether to keep both, or just one or the other.

I see two advantages with this realm: using avl.Trees + pagination, and providing users with a way to actually "write something" (with the consequence of moderation -- hence why there is an admin function the remove a user's post; though obviously with the faucet working anyone can just have another account).

cc @moul

Copy link

codecov bot commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.45%. Comparing base (68b8f54) to head (c76bba1).
Report is 9 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2345      +/-   ##
==========================================
+ Coverage   60.44%   60.45%   +0.01%     
==========================================
  Files         563      563              
  Lines       75157    75159       +2     
==========================================
+ Hits        45426    45436      +10     
+ Misses      26341    26333       -8     
  Partials     3390     3390              
Flag Coverage Δ
contribs/gnodev 61.46% <ø> (ø)
contribs/gnofaucet 14.46% <ø> (-0.86%) ⬇️
gno.land 67.21% <ø> (ø)
gnovm 64.46% <100.00%> (+<0.01%) ⬆️
misc/genstd 80.54% <ø> (ø)
misc/logos 20.23% <ø> (ø)
tm2 62.10% <ø> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@moul moul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but we should consider renaming this example to avoid conflicts with other guestbook implementations.

@thehowl thehowl changed the title feat(examples): add guestbook realm feat(examples): add r/morgan/{home,guestbook} Sep 12, 2024
@thehowl
Copy link
Member Author

thehowl commented Sep 12, 2024

Moved it to r/morgan/guestbook and added a small home realm. It seems appropriate for now.

@thehowl thehowl merged commit 41e0085 into master Sep 12, 2024
120 checks passed
@thehowl thehowl deleted the dev/morgan/guestbook branch September 12, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧾 package/realm Tag used for new Realms or Packages.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants