feat: overhaul gnoland secrets and gnoland config to output JSON
#2393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zivkovicmilos
requested review from
a team,
jaekwon,
moul and
piux2
as code owners
7 tasks
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2393 +/- ##
==========================================
+ Coverage 54.66% 54.68% +0.01%
==========================================
Files 583 583
Lines 78508 78502 -6
==========================================
+ Hits 42913 42925 +12
+ Misses 32384 32369 -15
+ Partials 3211 3208 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
On a single field, please remove the |
I added support for the |
moul
reviewed
Jun 19, 2024
moul
approved these changes
Jun 19, 2024
moul
reviewed
Jun 19, 2024
ajnavarro
approved these changes
Jun 19, 2024
gfanton
approved these changes
Jun 19, 2024
7 tasks
sw360cab
approved these changes
Jun 20, 2024
thehowl
reviewed
Jun 20, 2024
7 tasks
albttx
approved these changes
Jun 24, 2024
thehowl
reviewed
Jun 24, 2024
zivkovicmilos
referenced
this pull request
Jun 25, 2024
gfanton
pushed a commit
to gfanton/gno
that referenced
this pull request
Jul 23, 2024
…nolang#2393) ## Description This PR overhauls the `gnoland secrets get` and `gnoland config get` commands to: - always output JSON by default - support key paths for specific fields - have `-raw` support for single value JSON (escapes `"`) Thank you @moul for the suggestion on this 🙏  cc @albttx @sw360cab @r3v4s @mazzy89 <details><summary>Contributors' checklist...</summary> - [x] Added new tests, or not needed, or not feasible - [x] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory - [x] Updated the official documentation or not needed - [ ] No breaking changes were made, or a `BREAKING CHANGE: xxx` message was included in the description - [x] Added references to related issues and PRs - [x] Provided any useful hints for running manual tests - [ ] Added new benchmarks to [generated graphs](https://gnoland.github.io/benchmarks), if any. More info [here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md). </details>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR overhauls the
gnoland secrets getandgnoland config getcommands to:-rawsupport for single value JSON (escapes")Thank you @moul for the suggestion on this 🙏
cc @albttx @sw360cab @r3v4s @mazzy89
Contributors' checklist...
BREAKING CHANGE: xxxmessage was included in the description