feat: Initialize static blocks before preprocess #2418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2418 +/- ##
==========================================
- Coverage 54.92% 54.89% -0.04%
==========================================
Files 595 595
Lines 79447 79341 -106
==========================================
- Hits 43637 43551 -86
+ Misses 32516 32494 -22
- Partials 3294 3296 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jaekwon
changed the title
jaekwon
commented
Jun 24, 2024
gnovm/tests/files/assign_unnamed_type/more/realm_compositelit_filetest.gno
Show resolved
Hide resolved
|
Relates to #2077 |
Kouteki
requested review from
petar-dambovaliev
and removed request for
moul,
deelawn,
thehowl and
piux2
jaekwon
changed the title
petar-dambovaliev
approved these changes
Jul 5, 2024
moul
approved these changes
Jul 6, 2024
petar-dambovaliev
requested review from
ltzmaxwell
and removed request for
a team
gfanton
pushed a commit
to gfanton/gno
that referenced
this pull request
Jul 23, 2024
This PR introduces a phase 'initStaticBlock' to come before preprocess, where the StaticBlock name table is populated with BlockNode.Predefine() calls. initStaticBlock() also does a few other things, including giving default names where no names are provided, and making 'init' function names unique with numeric suffixes. --------- Co-authored-by: Petar Dambovaliev <petar.atanasov.1987@gmail.com>
7 tasks
thehowl
added a commit
that referenced
this pull request
Sep 16, 2024
fixes #2711 The bug in the benchmark was introduced in #2418, which requires to run initStaticBlocks before running Preprocess, in most cases. (in normal scenarios, this is run by PredefineFileSet; however this benchmark is deep into the internals). Related: #2716. cc/ @sw360cab <!-- please provide a detailed description of the changes made in this pull request. --> <details><summary>Contributors' checklist...</summary> - [ ] Added new tests, or not needed, or not feasible - [ ] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory - [ ] Updated the official documentation or not needed - [ ] No breaking changes were made, or a `BREAKING CHANGE: xxx` message was included in the description - [ ] Added references to related issues and PRs - [ ] Provided any useful hints for running manual tests - [ ] Added new benchmarks to [generated graphs](https://gnoland.github.io/benchmarks), if any. More info [here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md). </details>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a phase 'initStaticBlock' to come before preprocess, where the StaticBlock name table is populated with BlockNode.Predefine() calls.
initStaticBlock() also does a few other things, including giving default names where no names are provided, and making 'init' function names unique with numeric suffixes.