-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: align on-chain valset with genesis.json
valset
#2465
Draft
zivkovicmilos
wants to merge
49
commits into
master
Choose a base branch
from
dev/zivkovicmilos/poc-genesis
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+857
−82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 2be7527.
Co-authored-by: Manfred Touron <94029+moul@users.noreply.github.com>
github-actions
bot
added
🧾 package/realm
Tag used for new Realms or Packages.
📦 🤖 gnovm
Issues or PRs gnovm related
📦 🌐 tendermint v2
Issues or PRs tm2 related
labels
Jun 30, 2024
zivkovicmilos
changed the title
feat: align
feat: align on-chain valset with Jun 30, 2024
genesis.json
valset with on-chain valsetgenesis.json
valset
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2465 +/- ##
=======================================
Coverage 54.71% 54.71%
=======================================
Files 583 583
Lines 78499 78499
=======================================
+ Hits 42947 42953 +6
+ Misses 32344 32340 -4
+ Partials 3208 3206 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
zivkovicmilos
modified the milestones:
🏗4️⃣ test4.gno.land,
🏗4️⃣ test4.gno.land [POST LAUNCH]
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
📦 🌐 tendermint v2
Issues or PRs tm2 related
📦 ⛰️ gno.land
Issues or PRs gno.land package related
📦 🤖 gnovm
Issues or PRs gnovm related
🧾 package/realm
Tag used for new Realms or Packages.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Depends on #2130
This PR introduces an alignment between the
genesis.json
validator set (lives on-disk), and the on-chain validator set in the genesis transactions.How it works:
genesis.json
valsetconfig.toml
), and it's none by default (current behavior). The reasoning behind keeping it in the node'sconfig.toml
is to ensure this value is accessible from different stages of the chain pipeline (fromgenesis.json
generation ->EndBlocker
)r/sys/vals
Realm (the deployment transaction must be present in thegenesis.json
) before starting their chaingenesis.json
, ther/sys/vals
Realm deployment transaction is updated to reflect the current state in thegenesis.json
init
(constructor) part of ther/sys/vals
Realm is updated, to reflect the changes. We use Go's templates for this purpose as it's a simple pastecc @gfanton @moul
Contributors' checklist...
BREAKING CHANGE: xxx
message was included in the description