fix(gnovm): repair selector type aliasing #2483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deelawn
requested review from
jaekwon,
moul,
piux2,
thehowl and
mvertes
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2483 +/- ##
==========================================
- Coverage 54.92% 54.86% -0.06%
==========================================
Files 595 593 -2
Lines 79447 79349 -98
==========================================
- Hits 43637 43536 -101
- Misses 32516 32530 +14
+ Partials 3294 3283 -11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
moul
approved these changes
Jul 8, 2024
petar-dambovaliev
approved these changes
Jul 16, 2024
gfanton
pushed a commit
to gfanton/gno
that referenced
this pull request
Jul 23, 2024
Closes gnolang#2479. When defining a type alias to a type in another package, the existing type is specified with a selector expression. This PR ensures that the underlying type being aliased is properly extracted. <details><summary>Contributors' checklist...</summary> - [x] Added new tests, or not needed, or not feasible - [x] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory - [x] Updated the official documentation or not needed - [x] No breaking changes were made, or a `BREAKING CHANGE: xxx` message was included in the description - [x] Added references to related issues and PRs - [x] Provided any useful hints for running manual tests - [x] Added new benchmarks to [generated graphs](https://gnoland.github.io/benchmarks), if any. More info [here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md). </details> Co-authored-by: Manfred Touron <94029+moul@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2479.
When defining a type alias to a type in another package, the existing type is specified with a selector expression. This PR ensures that the underlying type being aliased is properly extracted.
Contributors' checklist...
BREAKING CHANGE: xxxmessage was included in the description