-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add pyroscope and updates compose #2536
Conversation
cc @sw360cab Not sure if this is something we want |
@thehowl To elabortate this makes local testing more feasible - the existing automation pulls from ghcr.io/gnolang/gno/gnoland which means its static. If you make a change to a By using the approach of a local build developers will be able to get immediate feedback on how their changes affect the node. pyroscope is an additional add to that. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2536 +/- ##
==========================================
- Coverage 60.16% 60.14% -0.02%
==========================================
Files 561 561
Lines 74999 74999
==========================================
- Hits 45120 45108 -12
- Misses 26500 26511 +11
- Partials 3379 3380 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This PR works on two different topics
I will close this and be happy to review code that works on the previous aspects in separeted PRs. |
@sw360cab thanks for the feedback - will create separate pr as suggested and reference this one. |
Contributors' checklist...
BREAKING CHANGE: xxx
message was included in the description