fix(gnovm): fix max names in block check #2645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2645 +/- ##
=======================================
Coverage 60.14% 60.15%
=======================================
Files 560 560
Lines 74738 74738
=======================================
+ Hits 44950 44957 +7
+ Misses 26400 26394 -6
+ Partials 3388 3387 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
thehowl
approved these changes
Jul 31, 2024
|
good catch, I'll be pedantic but do you think you can add a test that checks for this panic happening when we add the could be a unit test, or a code-generated filetest. |
Sure, I've added a test for this. |
piux2
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed this while reviewing #2429. The previous conditional could never evaluate to true:
if (1<<16 - 1) < sb.NumNames {.sb.NumNamesis auint16and the value it is being compared to,1<<16 - 1is the max uint16 value, so it is impossible the the number of names to be greater than this value. Instead, we should check to see if the current number of names is the maximum value and panic if this is the case.Contributors' checklist...
BREAKING CHANGE: xxxmessage was included in the description