Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix rpc consensus_state height_vote_set #2696

Closed
wants to merge 2 commits into from
Closed

chore: fix rpc consensus_state height_vote_set #2696

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1e1efc9
chore: RPC success response use json over amino
albttx Aug 14, 2024
d6f4813
Merge branch 'master' into fix/tm2-rpc-consensus-state
albttx Aug 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tm2/pkg/bft/rpc/lib/types/types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,7 @@ func NewRPCSuccessResponse(id JSONRPCID, res any) RPCResponse {

if res != nil {
var js []byte
js, err := amino.MarshalJSON(res)
js, err := json.Marshal(res)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we figure out why the Amino JSON is causing an empty object? What is the type of res?
Maybe we just need to register the package / type with Amino

It's now causing tests to fail, most likely because we use Amino JSON to unmarshal all responses / requests

if err != nil {
return RPCInternalError(id, errors.Wrap(err, "Error marshalling response"))
}
Expand Down
Loading