Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gnostats): add the agent #2706

Merged
merged 13 commits into from
Aug 28, 2024

Conversation

aeddi
Copy link
Contributor

@aeddi aeddi commented Aug 16, 2024

This PR introduces the gnostats agent that acts as a bridge between the Gno node RPC endpoint and gnostats Hub.

Part of #2666.

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

@github-actions github-actions bot added the 📦 🌐 tendermint v2 Issues or PRs tm2 related label Aug 16, 2024
Copy link

codecov bot commented Aug 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.15%. Comparing base (db418ff) to head (7882548).

Additional details and impacted files
@@                     Coverage Diff                     @@
##           dev/zivkovicmilos/gnostats    #2706   +/-   ##
===========================================================
  Coverage                       60.14%   60.15%           
===========================================================
  Files                             561      561           
  Lines                           74999    74999           
===========================================================
+ Hits                            45111    45113    +2     
+ Misses                          26509    26507    -2     
  Partials                         3379     3379           
Flag Coverage Δ
contribs/gnodev 61.40% <ø> (+0.81%) ⬆️
contribs/gnofaucet 14.46% <ø> (ø)
gno.land 64.75% <ø> (ø)
gnovm 64.13% <ø> (ø)
misc/genstd 80.54% <ø> (ø)
misc/logos 19.88% <ø> (ø)
tm2 62.06% <ø> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@zivkovicmilos zivkovicmilos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great 💯

There are just a few minor things to change, to make it perfect 🙂
Some areas can be simplified, and we can use different RPC endpoints on the client which would be more performant

tm2/pkg/p2p/node_info.go Outdated Show resolved Hide resolved
contribs/gnostats/agent/agent.go Outdated Show resolved Hide resolved
contribs/gnostats/agent/agent.go Outdated Show resolved Hide resolved
contribs/gnostats/agent/agent.go Outdated Show resolved Hide resolved
contribs/gnostats/agent/agent_test.go Outdated Show resolved Hide resolved
contribs/gnostats/agent/collector.go Outdated Show resolved Hide resolved
contribs/gnostats/agent/collector_test.go Show resolved Hide resolved
contribs/gnostats/agent/collector_test.go Outdated Show resolved Hide resolved
contribs/gnostats/agent/agent.go Outdated Show resolved Hide resolved
contribs/gnostats/agent/agent.go Outdated Show resolved Hide resolved
Copy link
Member

@zivkovicmilos zivkovicmilos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for applying the fixes 🙏

@aeddi aeddi merged commit e239985 into dev/zivkovicmilos/gnostats Aug 28, 2024
119 checks passed
@aeddi aeddi deleted the dev/aeddi/gnostats-agent branch August 28, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 🌐 tendermint v2 Issues or PRs tm2 related
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants