Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: pre-register test1 user to make interaction with boards easier #2823

Merged
merged 9 commits into from
Sep 26, 2024

Conversation

hthieu1110
Copy link
Contributor

@hthieu1110 hthieu1110 commented Sep 21, 2024

This PR is to resolve this issue #990 created by Manfred.

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

@github-actions github-actions bot added the 🧾 package/realm Tag used for new Realms or Packages. label Sep 21, 2024
Copy link

codecov bot commented Sep 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.92%. Comparing base (ca9eb4b) to head (c46f9d0).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2823   +/-   ##
=======================================
  Coverage   60.91%   60.92%           
=======================================
  Files         564      564           
  Lines       75267    75267           
=======================================
+ Hits        45849    45853    +4     
+ Misses      26047    26046    -1     
+ Partials     3371     3368    -3     
Flag Coverage Δ
contribs/gnodev 61.46% <ø> (ø)
contribs/gnofaucet 14.46% <ø> (ø)
gnovm 65.77% <ø> (ø)
misc/genstd 80.54% <ø> (ø)
misc/logos 20.23% <ø> (ø)
tm2 62.12% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hthieu1110 hthieu1110 marked this pull request as ready for review September 21, 2024 15:46
@hthieu1110 hthieu1110 requested review from a team as code owners September 21, 2024 15:46
@hthieu1110 hthieu1110 requested review from jaekwon and thehowl and removed request for a team September 21, 2024 15:46
@hthieu1110
Copy link
Contributor Author

thanks @thehowl for your reviews. I moved the test to normal tests, hope that've addressed all your feedbacks.

Copy link
Member

@thehowl thehowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good after removing file

examples/gno.land/r/demo/users/z_13_filetest.gno Outdated Show resolved Hide resolved
@hthieu1110
Copy link
Contributor Author

Thanks @thehowl , the file has been removed.

@thehowl
Copy link
Member

thehowl commented Sep 26, 2024

Please remember to allow maintainers to edit the PR.

This allows us to merge in master and make sure that the CI is succeeding. Thanks

@thehowl thehowl merged commit 0bfa8ff into gnolang:master Sep 26, 2024
117 of 119 checks passed
@omarsy omarsy deleted the feat/pregister-test1-on-users branch September 26, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧾 package/realm Tag used for new Realms or Packages.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants