-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(examples): malek's namespace #2831
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2831 +/- ##
==========================================
- Coverage 60.87% 60.85% -0.02%
==========================================
Files 563 563
Lines 75193 75193
==========================================
- Hits 45770 45762 -8
- Misses 26055 26065 +10
+ Partials 3368 3366 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, thanks for the PR. We would like to have as many examples as possible for different home realms, as we will have a competition of them soon. It would be cool if you were to experiment and add different things. Copying the same code does not bring that much value to the examples/ folder.
mhh. it's ok, he can modify later? it can be a start of a fork. :) |
I didn't have no inspiration on what to add. What could you suggest? |
Sure, but I still disagree; why not start the fork in the PR? 😄 I want to see diversity and creativity in the examples, not a bunch of almost identical packages. Down the line this might bring lots of PRs with the identical approach. Here is a PR made after my home realm Live Coding session, which has a completely different (albeit bad because of HTML) approach.
Sorry, I don't have any ideas right now - if I had them, I would use them for my own home realm. Remember, this is your home page. Try to draw inspiration from other websites, or make something completely new :) |
related to leon's PR, and namespaces doc
Contributors' checklist...
BREAKING CHANGE: xxx
message was included in the description