Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(examples): malek's namespace #2831

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

MalekLahbib
Copy link
Contributor

@MalekLahbib MalekLahbib commented Sep 22, 2024

related to leon's PR, and namespaces doc

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

@MalekLahbib MalekLahbib requested review from a team as code owners September 22, 2024 14:52
@MalekLahbib MalekLahbib requested review from deelawn and piux2 and removed request for a team September 22, 2024 14:52
@github-actions github-actions bot added the 🧾 package/realm Tag used for new Realms or Packages. label Sep 22, 2024
Copy link

codecov bot commented Sep 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.85%. Comparing base (9897b66) to head (a793443).
Report is 26 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2831      +/-   ##
==========================================
- Coverage   60.87%   60.85%   -0.02%     
==========================================
  Files         563      563              
  Lines       75193    75193              
==========================================
- Hits        45770    45762       -8     
- Misses      26055    26065      +10     
+ Partials     3368     3366       -2     
Flag Coverage Δ
contribs/gnodev 61.46% <ø> (ø)
contribs/gnofaucet 14.46% <ø> (-0.86%) ⬇️
gno.land 67.17% <ø> (ø)
gnovm 65.63% <ø> (ø)
misc/genstd 80.54% <ø> (ø)
misc/logos 19.88% <ø> (-0.36%) ⬇️
tm2 62.07% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@leohhhn leohhhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks for the PR. We would like to have as many examples as possible for different home realms, as we will have a competition of them soon. It would be cool if you were to experiment and add different things. Copying the same code does not bring that much value to the examples/ folder.

@thehowl
Copy link
Member

thehowl commented Sep 23, 2024

Hey, thanks for the PR. We would like to have as many examples as possible for different home realms, as we will have a competition of them soon. It would be cool if you were to experiment and add different things. Copying the same code does not bring that much value to the examples/ folder.

mhh. it's ok, he can modify later?

it can be a start of a fork. :)

@MalekLahbib
Copy link
Contributor Author

Hey, thanks for the PR. We would like to have as many examples as possible for different home realms, as we will have a competition of them soon. It would be cool if you were to experiment and add different things. Copying the same code does not bring that much value to the examples/ folder.

I didn't have no inspiration on what to add. What could you suggest?

@leohhhn
Copy link
Contributor

leohhhn commented Sep 30, 2024

@thehowl

mhh. it's ok, he can modify later?

it can be a start of a fork. :)

Sure, but I still disagree; why not start the fork in the PR? 😄
In the state it is right now, the PR will add little to no value to the codebase, simply because it's mostly a copy. People can use permissionless deployments for this type of stuff.

I want to see diversity and creativity in the examples, not a bunch of almost identical packages. Down the line this might bring lots of PRs with the identical approach.

Here is a PR made after my home realm Live Coding session, which has a completely different (albeit bad because of HTML) approach.

@MalekLahbib

I didn't have no inspiration on what to add. What could you suggest?

Sorry, I don't have any ideas right now - if I had them, I would use them for my own home realm. Remember, this is your home page. Try to draw inspiration from other websites, or make something completely new :)

@Kouteki Kouteki added review/triage-pending PRs opened by external contributors that are waiting for the 1st review and removed review/triage-pending PRs opened by external contributors that are waiting for the 1st review labels Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧾 package/realm Tag used for new Realms or Packages.
Projects
Status: In Progress
Status: In Review
Development

Successfully merging this pull request may close these issues.

4 participants