Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(p/int256): Optimize int256 with two's complement implementation #2846

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

notJoon
Copy link
Member

@notJoon notJoon commented Sep 25, 2024

Description

This PR optimizes the implementation of int256 type. Key changes include:

  • Changed from storing sign and value separately in the Int256 struct to an implementation using two's complement method.
  • This reduces unnecessary operations and improves overall performance.

Performance Result

  • Basic arithmetic operations (addition, subtraction, etc.): About 3x performance improvement (based on Go benchmarks, may differ slightly in gno)
  • Division operations: Up to 5x performance decrease compared to the previous implementation (can be improved by directly manipulating array fields, but not applied to avoid duplication with p/demo/uint256)

Additional improvements:

  • Increased test coverage to 95%.

This change is expected to improve performance for most int256 operations. However, please note the performance degradation in division operations.

See Also

#2750 (review)

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

@github-actions github-actions bot added the 🧾 package/realm Tag used for new Realms or Packages. label Sep 25, 2024
Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.94%. Comparing base (577c462) to head (641da4e).
Report is 10 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2846      +/-   ##
==========================================
+ Coverage   60.92%   60.94%   +0.02%     
==========================================
  Files         564      564              
  Lines       75267    75385     +118     
==========================================
+ Hits        45854    45947      +93     
- Misses      26041    26048       +7     
- Partials     3372     3390      +18     
Flag Coverage Δ
contribs/gnodev 60.65% <ø> (-0.82%) ⬇️
contribs/gnofaucet 15.31% <ø> (+0.85%) ⬆️
gno.land 67.17% <ø> (ø)
gnovm 65.77% <ø> (+<0.01%) ⬆️
misc/genstd 80.54% <ø> (ø)
misc/logos 20.23% <ø> (ø)
tm2 62.06% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@notJoon notJoon marked this pull request as ready for review September 26, 2024 09:19
@notJoon notJoon requested review from a team as code owners September 26, 2024 09:19
@notJoon notJoon requested review from gfanton and petar-dambovaliev and removed request for a team September 26, 2024 09:19
//
// This function is convenient for operations that require a unit value,
// such as incrementing or serving as an identity element in multiplication.
func One() *Int { return int1 }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this return a pointer to a copy?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

2ced198

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧾 package/realm Tag used for new Realms or Packages.
Projects
Status: No status
Status: In Review
Status: In Review
Development

Successfully merging this pull request may close these issues.

2 participants