Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gonative): add constant information when we define a go native value #2848

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

omarsy
Copy link
Contributor

@omarsy omarsy commented Sep 25, 2024

First part of the fix: #2836

The second part is addressed here: #2731

@github-actions github-actions bot added the 📦 🤖 gnovm Issues or PRs gnovm related label Sep 25, 2024
Copy link

codecov bot commented Sep 25, 2024

Codecov Report

Attention: Patch coverage is 97.56098% with 1 line in your changes missing coverage. Please review.

Project coverage is 60.93%. Comparing base (69400d4) to head (fa45914).

Files with missing lines Patch % Lines
gnovm/pkg/gnolang/gonative.go 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2848      +/-   ##
==========================================
+ Coverage   60.90%   60.93%   +0.02%     
==========================================
  Files         564      564              
  Lines       75273    75277       +4     
==========================================
+ Hits        45844    45869      +25     
+ Misses      26057    26041      -16     
+ Partials     3372     3367       -5     
Flag Coverage Δ
contribs/gnodev 61.46% <ø> (ø)
contribs/gnofaucet 15.31% <ø> (+0.85%) ⬆️
gno.land 67.17% <ø> (ø)
gnovm 65.78% <97.56%> (+<0.01%) ⬆️
misc/genstd 80.54% <ø> (ø)
misc/logos 19.88% <ø> (ø)
tm2 62.08% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@omarsy omarsy marked this pull request as ready for review September 25, 2024 14:34
@omarsy omarsy changed the title fix(gonative): add constant information when we define a go native v… fix(gonative): add constant information when we define a go native value Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 🤖 gnovm Issues or PRs gnovm related
Projects
Status: No status
Status: In Review
Development

Successfully merging this pull request may close these issues.

Assignment to Constant Pkg Value in Gno
1 participant