-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(gno.land/sdk/vm): add unit tests for Msg*.ValidateBasic
#2855
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2855 +/- ##
==========================================
+ Coverage 60.91% 60.95% +0.04%
==========================================
Files 564 564
Lines 75273 75273
==========================================
+ Hits 45851 45884 +33
+ Misses 26053 26015 -38
- Partials 3369 3374 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
LGTM, cross reference #2409 (review) for future improve, at least we can add |
Msg*.ValidateBasic
yes; though we already test it in keeper_test.go ;) |
The
vm Msg
is not yet covered by unit testsContributors' checklist...
BREAKING CHANGE: xxx
message was included in the description