-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add the stdlib_diff tool to compare gno and go standard libraries #2869
base: master
Are you sure you want to change the base?
Conversation
…tion is the standard gno library
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2869 +/- ##
=======================================
Coverage 60.90% 60.91%
=======================================
Files 564 564
Lines 75273 75273
=======================================
+ Hits 45844 45851 +7
+ Misses 26057 26052 -5
+ Partials 3372 3370 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
package main | ||
|
||
import ( | ||
"slices" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thehowl on Dec 13, 2023
seeing as you are importing slices, please add a go.mod file in this directory putting the go version at go 1.21
fixed on eaf6a87
return len(p.SrcFiles) == len(p.DstFiles) | ||
} | ||
|
||
// listDirFiles returns a list of file names in the specified directory. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thehowl on Dec 13, 2023
Prefer os.ReadDir
fixed on eaf6a87
@thehowl I took a look of this, the current status: 4 and 5 are fixed on eaf6a87
|
continuing the work started on #1425
thanks FloRichardAloeCorp for the great job on this issue 👍
closes #1310
Contributors' checklist...
BREAKING CHANGE: xxx
message was included in the description