Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip: use wal file to replay chain #2885

Closed
wants to merge 3 commits into from
Closed

Conversation

thehowl
Copy link
Member

@thehowl thehowl commented Oct 2, 2024

related: #2751, #1509, #1511

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

@thehowl thehowl self-assigned this Oct 2, 2024
@github-actions github-actions bot added 📦 🌐 tendermint v2 Issues or PRs tm2 related 📦 ⛰️ gno.land Issues or PRs gno.land package related labels Oct 2, 2024
Copy link

codecov bot commented Oct 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 60.92%. Comparing base (09b6241) to head (fdb69d6).
Report is 86 commits behind head on master.

Files with missing lines Patch % Lines
tm2/pkg/bft/consensus/replay_file.go 0.00% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2885      +/-   ##
==========================================
+ Coverage   60.90%   60.92%   +0.01%     
==========================================
  Files         564      564              
  Lines       75273    75267       -6     
==========================================
+ Hits        45846    45854       +8     
+ Misses      26055    26041      -14     
  Partials     3372     3372              
Flag Coverage Δ
contribs/gnodev 61.46% <ø> (ø)
contribs/gnofaucet 14.46% <ø> (ø)
gnovm 65.77% <ø> (ø)
misc/genstd 80.54% <ø> (ø)
misc/logos 19.88% <ø> (ø)
tm2 62.08% <0.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thehowl
Copy link
Member Author

thehowl commented Nov 6, 2024

We've done #2941 in place of this

I still believe we should actually have per-block replication, re-using much of the existing wal functionality which allows us to replay entirely the BFT state by keeping track of all the operations ongoing; but I digress. I'll point to this as "I told you so" if that happens

@thehowl thehowl closed this Nov 6, 2024
@thehowl thehowl deleted the dev/morgan/height-recover branch November 6, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 🌐 tendermint v2 Issues or PRs tm2 related 📦 ⛰️ gno.land Issues or PRs gno.land package related
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant