fix: deprecate std.GetOrigCaller

[n0izn0iz]

Contributors' checklist...

• Added new tests, or not needed, or not feasible
• Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
• Updated the official documentation or not needed
• No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
• Added references to related issues and PRs
• Provided any useful hints for running manual tests
• Added new benchmarks to generated graphs, if any. More info here.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.96%. Comparing base (8a62a28) to head (9cf6e30).
Report is 91 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #2906   +/-   ##
=======================================
  Coverage   60.95%   60.96%           
=======================================
  Files         564      564           
  Lines       75273    75273           
=======================================
+ Hits        45884    45889    +5     
+ Misses      26019    26012    -7     
- Partials     3370     3372    +2     

Flag	Coverage Δ
contribs/gnodev	61.46% <ø> (ø)
contribs/gnofaucet	14.46% <ø> (ø)
gno.land	67.92% <ø> (ø)
misc/genstd	80.54% <ø> (ø)
misc/logos	19.88% <ø> (ø)
tm2	62.09% <ø> (+0.02%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[n0izn0iz]

from @leohhhn

Might sound weird coming from me, but we should possibly keep it. i've found a few occasions where i found it useful.
We should have PrevRealm or its equivalent as the primary, non-limiting choice, while keeping OriginCaller as a specific functionality, discouraging it unless the user really knows what they're doing.
checkout RegisterCode(): https://gno.land/r/gc24/raffle/raffle.gno

What is the advantage or GetOrigCaller vs taking the address as input?

[thehowl]

For stdlibs, we'll err on the side of caution and add things after launch if necessary. So, relating to Leon's point, I'd remove it then add it back if necessary.

[leohhhn]

@n0izn0iz

What is the advantage or GetOrigCaller vs taking the address as input?

The difference is that the developer can enforce this rule. If the address was an input, the user could put in any random address.

In my specific example, I needed the realm calling my realm to be deployed by the same user that did some other action. This specific case I've seen a couple of times.

[n0izn0iz]

@leohhhn wdyt about getting the user address by inspecting the PrevRealm() pkg path and calling users.Resolve if it's a namespace?

[moul]

Blocking to prevent merging until the necessary discussions have taken place.

[thehowl]

We'll actually be keeping GetOriginCaller for now: #1475 (comment)

Thanks!