Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: clean up the params keeper #3105

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
+679 −393

Merge branch 'master' into dev/zivkovicmilos/params-cleanup

1a5b33b
Select commit
Loading
Failed to load commit list.
Open

chore: clean up the params keeper #3105

Merge branch 'master' into dev/zivkovicmilos/params-cleanup
1a5b33b
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 15, 2024 in 0s

63.77% (-0.02%) compared to 38736e7

View this Pull Request on Codecov

63.77% (-0.02%) compared to 38736e7

Details

Codecov Report

Attention: Patch coverage is 84.66667% with 23 lines in your changes missing coverage. Please review.

Project coverage is 63.77%. Comparing base (38736e7) to head (1a5b33b).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
gno.land/pkg/sdk/vm/builtins.go 21.42% 8 Missing and 3 partials ⚠️
tm2/pkg/sdk/params/keeper.go 94.87% 3 Missing and 1 partial ⚠️
gno.land/pkg/gnoland/param.go 81.25% 2 Missing and 1 partial ⚠️
gno.land/pkg/sdk/vm/keeper.go 50.00% 2 Missing and 1 partial ⚠️
gno.land/pkg/gnoland/app.go 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3105      +/-   ##
==========================================
- Coverage   63.78%   63.77%   -0.02%     
==========================================
  Files         549      548       -1     
  Lines       78819    78839      +20     
==========================================
+ Hits        50275    50276       +1     
- Misses      25153    25167      +14     
- Partials     3391     3396       +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov