chore: wrap precompile filename and tags logic #484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make precompile targetFilename and tags logic reusable by wrapping it in a function. Signed-off-by: Hariom Verma <hariom.verma@tendermint.com>
harry-hov
force-pushed
the
hariom/wrap-precompile-filename-tag-logic
branch
from
a3a079f
to
291845e
Compare
zivkovicmilos
approved these changes
Jan 27, 2023
|
We should keep the official pkgs as minimal as possible. What usages for external people are you expecting? If it's just for internal use, let's start having an internal/ pkgs folders. |
|
@moul I agree with you. Since this pkg has the ability to precompile files. IMHO it should also have the ability to get filename/tags for precompiled files. But I'm also okay with having internal/pkgs folders. I will go with whatever the team suggests. |
moul
approved these changes
Jan 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make precompile targetFilename and tags logic reusable by wrapping it in a function.