Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mod): utilize ~/.gno dir #652

Merged
merged 1 commit into from
Mar 27, 2023

Conversation

harry-hov
Copy link
Contributor

@harry-hov harry-hov commented Mar 26, 2023

Related: #462

See discussion: #479 (comment)

@harry-hov harry-hov requested a review from a team as a code owner March 26, 2023 19:55
@harry-hov harry-hov requested a review from moul March 26, 2023 19:58
@thehowl
Copy link
Member

thehowl commented Mar 26, 2023

Mhhh. I personally dislike it when software create a new directory in my $HOME. I would rather they used ~/.local/share/ or ~/.cache.

I don't know if this conversation was already had previously, but if we're extending the use of GNO_HOME, I think we should consider having it elsewhere?

@moul
Copy link
Member

moul commented Mar 27, 2023

What about following other standards such as the XDG_ and other well-known environment variables, in order to adhere to best practices on various systems and allow users to override the default value if desired?

@moul
Copy link
Member

moul commented Mar 27, 2023

This PR does not involve creating a new folder, but rather reusing the existing one that is created and used globally for gno.

Let's take a closer look at @harry-hov's work for this addition which is finally more as a merge + making gno more independent from go in terms of FS (which is good IMO). Then reevaluate if we should pursue a different approach for managing config-dirs globally. @thehowl, what are your thoughts on my previous comment?

Copy link
Member

@moul moul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the PR

We would like to ensure that @thehowl's valid concern is addressed before merging, for example, by inserting or updating issues.

@thehowl
Copy link
Member

thehowl commented Mar 27, 2023

@moul Created #655 for that

@thehowl thehowl merged commit c128f13 into gnolang:master Mar 27, 2023
peter7891 pushed a commit that referenced this pull request Mar 29, 2023
@harry-hov harry-hov mentioned this pull request Apr 13, 2023
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants