feat(test): support *OriginCall funcs in _test files
#703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix gnolang#481 `AssertOriginCall` and `IsOriginCall` functions can be used inside contracts to determine if the call comes directly from a tx (which is an *origin call*) or from an other contract (not an *origin call*). To do this those functions count the number of frames. In production environment, if there's exactly 2 frames, it is considered as an *origin call*. In test environment, the number of frames was 3, but it was working only for `_filetest`, and not for `_test`, where the setup is different and so the number of frames (7 instead of 3). To support `_test`, the change brings a way to identify if a test is a `_test` or `_filetest`, by checking the function name of the first frame. There's currently a pending discussion (gnolang#683) about how we should deal with frames, that's why I tried to keep this change minimal, but at least it fixes something and we can move forward. Ideally, `*OriginCall` functions should rely on something stronger that the number of frames, because for instance they could consider that a call is not an *origin call*, just because `std.IsOriginCall` is called by a sub-function of the same contract. But that's something we'll probably tackle with gnolang#683.
thehowl
changed the title
*OriginCall funcs in _test files*OriginCall funcs in _test files
Not usable right now because it imports `sort.Sort` which is disabled in tests.
Since p/demo/tests source code has been changed, some golden outputs have to be updated.
|
Finally fixed the tests, I had to remove the |
moul
approved these changes
Apr 12, 2023
peter7891
pushed a commit
that referenced
this pull request
May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #481
Description
AssertOriginCallandIsOriginCallfunctions can be used inside contracts to determine if the call comes directly from a tx (which is an origin call) or from an other contract (not an origin call).To do this those functions count the number of frames. In production environment, if there's exactly 2 frames, it is considered as an origin call. In test environment, the number of frames was 3, but it was working only for
_filetest, and not for_test, where the setup is different and so the number of frames (7 instead of 3).Change
To support
_test, the change brings a way to identify if a test is a_testor_filetest, by checking the function name of the first frame.There's currently a pending discussion (#683) about how we should deal with frames, that's why I tried to keep this change minimal, but at least it fixes something and we can move forward.
This replaces the previous attempt #495 which was more complicated and actually was not correct.
Next steps
Ideally,
*OriginCallfunctions should rely on something stronger that the number of frames, because for instance they could consider that a call is not an origin call, just becausestd.IsOriginCallis called by a sub-function of the same contract. But that's something we'll probably tackle with #683.How has this been tested?
Some new tests have been added to
r/demo/tests. Note that because we need to catch the panic inside the gno test,panichas been replaced bym.Panic(as explained in #663).