-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: new realm /r/demo/microblog #791
Conversation
This check is failing on the CI:
I don't understand why. I can run the same command on my local repo and it reports no errors. |
The difference might be that the CI runs To improve error clarity, it would be helpful to display the mapped |
Thanks that was the trick I needed. I added that to my workflow and I'll be able to catch these errors from now on. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love the idea 💯
Thank you for opening up the PR 🙏
I've left a few comments we should discuss before merging
Thanks @ajnavarro, @zivkovicmilos will make edits for these this weekend! Appreciate your help. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great realm 👍
I personally find Page
for the user's posts confusing. (page makes me think of pagination, of a limited set of entries). What about Feed or Profile?
Have you thought about possibly integrating gno.land/r/demo/users
for friendlier names? :)
Yes, @thehowl - this is a great idea. I'm not sure about the strategy do I either
OR
? |
@schollz just do an import! a key feature of gno is that realm-to-realm calls are done just by importing the realm :) |
Its much better now, thanks @thehowl . The microblog now automatically displays user names if they are found in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pre-approving, looks good everywhere else 👍
* add /r/demo/microblog * remove unused imports * fix: remove unused imports and error handling * sort by last updated * split out rendering into multiple functions * better error handling * NewPage is private * turn print statements to tests * fix typo * move comments to README * remove unused tests * add status not found * refactor to new avl.Node iterator * revert genesis_balances.txt * remove redundant newPage * format time to ensure alphabetical sorting * time bug formatting fix * improved ui * unexport byLastPosted * use registered users data when available * remove redundant types
Description
This is a realm exploring the idea of microblogging, where each page is routed by the user's address and each page shows a sorted list of entries from that user. This is a starting point for future realms that may incorporate incentivizing of posts, but wanted to get a working MVP. I believe this realm also serves as a nice intro into Gno (similar to blog) but here it has an exceedingly simple API and demonstrates the utility of content addressing.
How has this been tested?
Yes, I've tested this by setting up my own genesis block and using that to add the package, realm, and submit posts to the realm.