feat: Add Ownable, proper sort by timestamp #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for gno-memeland canceled.
|
zivkovicmilos
approved these changes
Mar 18, 2024
deelawn
reviewed
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds
Ownableto the Memeland realm, and introduces aRemovePost()for handling moderation of posts.It also introduces proper sorting by the timestamp the memes were created, as prevously it was purely based on the order of addition.
This PR also makes all of the tests for the Memeland package better, and adds tests for newly introduced functionality.
Considerations: If we choose to deploy the realm via genesis, ownership needs to be transferred to a trusted address in the
init()of the realm.