-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider making the source extraction straight in this repo. #2
Comments
Extractor service that works in tandem with @zivkovicmilos' tx-archive tool is in reviews currently (PR #5). I propose a refactor to this repo:
We can configure GH actions to activate the extractor service once the archiving service is done with its work. |
leohhhn
added a commit
to leohhhn/tx-exports
that referenced
this issue
Dec 21, 2023
Co-authored-by: Antonio Navarro Perez <antnavper@gmail.com>
leohhhn
added a commit
that referenced
this issue
Dec 29, 2023
* add extractor * file refactor * added walker log file discovery * add whitespace * WIP full refactor in progress * fixed decoding * add tests, updated README * removed unused errors, removed args * test fixes * fix typo * fix newlines * rename function * remove variable, expand err msg * edit error message * replace conditionals with require * replace conditional with require#2 * add cleanup helper, replace defer with t.cleanup * reorg args * add t.Helper() * replace t.fatal with require * fix arg order * modify random string func in testing * replace t.Fatalf with require * move global variables to smaller scopes * rename error Co-authored-by: Antonio Navarro Perez <antnavper@gmail.com> * remove unused anon vars Co-authored-by: Antonio Navarro Perez <antnavper@gmail.com> * edit comment Co-authored-by: Antonio Navarro Perez <antnavper@gmail.com> * rename error Co-authored-by: Antonio Navarro Perez <antnavper@gmail.com> * update map storage for paths Co-authored-by: Antonio Navarro Perez <antnavper@gmail.com> * update map storage for paths #2 Co-authored-by: Antonio Navarro Perez <antnavper@gmail.com> * add conversion check Co-authored-by: Antonio Navarro Perez <antnavper@gmail.com> * add error check Co-authored-by: Antonio Navarro Perez <antnavper@gmail.com> * format & handle errors * move cleanup above err check * Revert "move cleanup above err check" This reverts commit 872fd12. * swap arg order * wip tests * added more tests * modify source path * parallel test failing, save * fix broken tests --------- Co-authored-by: Antonio Navarro Perez <antnavper@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
See gnolang/hackerspace#39.
Could be enough to just have a subfolder like
src/{testnet}/{p,r}/...
.Tagging @albttx, @waymobetta, and @leohhhn for attention, but others are welcome to contribute as well.
The text was updated successfully, but these errors were encountered: