Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: expose additional tx fields #32

Merged
merged 8 commits into from
Apr 24, 2024
Merged

feat: expose additional tx fields #32

merged 8 commits into from
Apr 24, 2024

Conversation

zivkovicmilos
Copy link
Member

@zivkovicmilos zivkovicmilos commented Apr 11, 2024 •
edited
Loading

Description

This PR exposes additional TxResult fields to the graphQL interface:

  • response info
  • response log
  • response data
  • response error

@zivkovicmilos zivkovicmilos self-assigned this Apr 11, 2024
ajnavarro
ajnavarro reviewed Apr 11, 2024
View reviewed changes
serve/graph/model/transaction.go Outdated Show resolved Hide resolved
serve/graph/schema/types/transaction.graphql Outdated Show resolved Hide resolved
serve/graph/transaction.resolvers.go Outdated Show resolved Hide resolved
@jinoosss jinoosss requested a review from ajnavarro April 17, 2024 04:41
@zivkovicmilos zivkovicmilos marked this pull request as ready for review April 18, 2024 08:35
@zivkovicmilos zivkovicmilos requested a review from a team as a code owner April 18, 2024 08:35
@zivkovicmilos
Copy link
Member Author

@jinoosss can you please update this PR with the latest main changes? 🙏

@zivkovicmilos
Copy link
Member Author

I think we should be good to go, just waiting on @ajnavarro to give the final approve for the resolved comments

ajnavarro
ajnavarro requested changes Apr 22, 2024
View reviewed changes
serve/graph/transaction.resolvers.go Outdated Show resolved Hide resolved
@jinoosss jinoosss requested a review from ajnavarro April 22, 2024 17:56
ajnavarro
ajnavarro requested changes Apr 23, 2024
View reviewed changes
Copy link
Collaborator

@ajnavarro ajnavarro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor change and after that we can merge!

serve/graph/model/transaction.go Outdated Show resolved Hide resolved
jinoosss and others added 2 commits April 23, 2024 19:31
@jinoosss @ajnavarro
Update serve/graph/model/transaction.go
0425456 
Co-authored-by: Antonio Navarro Perez <antnavper@gmail.com>
@jinoosss
chore: Update generated
035b818
@jinoosss jinoosss requested a review from ajnavarro April 23, 2024 10:32
@ajnavarro ajnavarro merged commit 27290c6 into main Apr 24, 2024
3 checks passed
@zivkovicmilos zivkovicmilos deleted the feat/expose-tx-errors branch April 24, 2024 16:54
@Kouteki Kouteki mentioned this pull request May 6, 2024
Open
@michelleellen michelleellen mentioned this pull request May 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jinoosss jinoosss jinoosss left review comments

@ajnavarro ajnavarro ajnavarro approved these changes

Assignees

@zivkovicmilos zivkovicmilos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zivkovicmilos @ajnavarro @jinoosss