conflicting UUID when cloning layout

[arshbot]

terminator 1.92
arch 5.6.15

Steps to reproduce:

1. Open terminator for first time.
2. Adjust arbitrarily and create a new layout based on adjustments
3. Clone layout and rename layout.
4. launch layout with terminator -l my_layout_name
5. terminator will launch without provisioning shell

Relevant information:

In original terminal client ( from where you ran terminator -d -l my_layout_name ) the following error is outputted

ConfigBase::__init__: Borg::__init__: Preparing borg state for ConfigBase
noclass::get_config_dir: Found config dir: /home/harshagoli/.config
ConfigBase::load: looking for config file: /home/harshagoli/.config/terminator/config
ConfigBase::load: config validated successfully
ConfigBase::load: ConfigBase::load: Processing section: global_config
ConfigBase::load: ConfigBase::load: Processing section: keybindings
ConfigBase::load: ConfigBase::load: Processing keybindings: zoom_in
ConfigBase::load: ConfigBase::load: Processing keybindings: zoom_out
ConfigBase::load: ConfigBase::load: Processing keybindings: zoom_normal
ConfigBase::load: ConfigBase::load: Processing keybindings: new_tab
ConfigBase::load: ConfigBase::load: Processing keybindings: cycle_next
ConfigBase::load: ConfigBase::load: Processing keybindings: cycle_prev
ConfigBase::load: ConfigBase::load: Processing keybindings: go_next
ConfigBase::load: ConfigBase::load: Processing keybindings: go_prev
ConfigBase::load: ConfigBase::load: Processing keybindings: go_up
ConfigBase::load: ConfigBase::load: Processing keybindings: go_down
ConfigBase::load: ConfigBase::load: Processing keybindings: go_left
ConfigBase::load: ConfigBase::load: Processing keybindings: go_right
ConfigBase::load: ConfigBase::load: Processing keybindings: rotate_cw
ConfigBase::load: ConfigBase::load: Processing keybindings: rotate_ccw
ConfigBase::load: ConfigBase::load: Processing keybindings: split_horiz
ConfigBase::load: ConfigBase::load: Processing keybindings: split_vert
ConfigBase::load: ConfigBase::load: Processing keybindings: close_term
ConfigBase::load: ConfigBase::load: Processing keybindings: copy
ConfigBase::load: ConfigBase::load: Processing keybindings: paste
ConfigBase::load: ConfigBase::load: Processing keybindings: toggle_scrollbar
ConfigBase::load: ConfigBase::load: Processing keybindings: search
ConfigBase::load: ConfigBase::load: Processing keybindings: close_window
ConfigBase::load: ConfigBase::load: Processing keybindings: resize_up
ConfigBase::load: ConfigBase::load: Processing keybindings: resize_down
ConfigBase::load: ConfigBase::load: Processing keybindings: resize_left
ConfigBase::load: ConfigBase::load: Processing keybindings: resize_right
ConfigBase::load: ConfigBase::load: Processing keybindings: move_tab_right
ConfigBase::load: ConfigBase::load: Processing keybindings: move_tab_left
ConfigBase::load: ConfigBase::load: Processing keybindings: toggle_zoom
ConfigBase::load: ConfigBase::load: Processing keybindings: scaled_zoom
ConfigBase::load: ConfigBase::load: Processing keybindings: next_tab
ConfigBase::load: ConfigBase::load: Processing keybindings: prev_tab
ConfigBase::load: ConfigBase::load: Processing keybindings: full_screen
ConfigBase::load: ConfigBase::load: Processing keybindings: reset
ConfigBase::load: ConfigBase::load: Processing keybindings: reset_clear
ConfigBase::load: ConfigBase::load: Processing keybindings: hide_window
ConfigBase::load: ConfigBase::load: Processing keybindings: group_all
ConfigBase::load: ConfigBase::load: Processing keybindings: ungroup_all
ConfigBase::load: ConfigBase::load: Processing keybindings: group_tab
ConfigBase::load: ConfigBase::load: Processing keybindings: ungroup_tab
ConfigBase::load: ConfigBase::load: Processing keybindings: new_window
ConfigBase::load: ConfigBase::load: Processing keybindings: new_terminator
ConfigBase::load: ConfigBase::load: Processing keybindings: broadcast_off
ConfigBase::load: ConfigBase::load: Processing keybindings: broadcast_group
ConfigBase::load: ConfigBase::load: Processing keybindings: broadcast_all
ConfigBase::load: ConfigBase::load: Processing keybindings: insert_number
ConfigBase::load: ConfigBase::load: Processing keybindings: insert_padded
ConfigBase::load: ConfigBase::load: Processing keybindings: edit_window_title
ConfigBase::load: ConfigBase::load: Processing keybindings: edit_tab_title
ConfigBase::load: ConfigBase::load: Processing keybindings: edit_terminal_title
ConfigBase::load: ConfigBase::load: Processing keybindings: layout_launcher
ConfigBase::load: ConfigBase::load: Processing keybindings: help
ConfigBase::load: ConfigBase::load: Processing section: profiles
ConfigBase::load: ConfigBase::load: Processing profile: default
ConfigBase::load: ConfigBase::load: Processing profile: Cobalt2
ConfigBase::load: ConfigBase::load: Processing section: layouts
ConfigBase::load: ConfigBase::load: Processing layouts: default
ConfigBase::load: ConfigBase::load: Processing layouts: main
ConfigBase::load: ConfigBase::load: Processing section: plugins
Config::set_profile: Config::set_profile: Changing profile to default
Config::connect_gsetting_callbacks: GSetting connects for system changes
noclass::parse_options: OptionParse::parse_options: command line options: {'version': None, 'maximise': None, 'fullscreen': None, 'borderless': None, 'hidden': None, 'forcedtitle': None, 'geometry': None, 'command': None, 'config': '/home/harshagoli/.config/terminator/config', 'execute': None, 'working_directory': None, 'forcedicon': None, 'role': None, 'layout': 'main', 'select': None, 'profile': None, 'nodbus': None, 'debug': 1, 'debug_classes': None, 'debug_methods': None, 'new_tab': None, 'dummy': None}
ConfigBase::load: ConfigBase::load: config already loaded
Config::set_profile: Config::set_profile: Changing profile to default
Config::connect_gsetting_callbacks: GSetting connects for system changes
ConfigBase::get_item: ConfigBase::get_item: dbus found in globals: True
function::with_proxy: dbus client call: new_window_cmdline
function::with_proxy: dbus client call: new_tab_cmdline
function::with_proxy: dbus client call: new_window
function::with_proxy: dbus client call: new_tab
function::with_proxy: dbus client call: hsplit
function::with_proxy: dbus client call: vsplit
function::with_proxy: dbus client call: get_terminals
function::with_proxy: dbus client call: get_window
function::with_proxy: dbus client call: get_window_title
function::with_proxy: dbus client call: get_tab
function::with_proxy: dbus client call: get_tab_title
DBusService::__init__: Borg::__init__: Preparing borg state for DBusService
DBusService::prepare_attributes: Checking for bus name availability: net.tenshu.Terminator25ef4b219e3b005583550f2b0f9f990c3
DBusService::prepare_attributes: bus name unavailable: net.tenshu.Terminator25ef4b219e3b005583550f2b0f9f990c3
noclass::<module>: Unable to become master process, operating via DBus
noclass::<module>: Requesting a new window
Traceback (most recent call last):
  File "/usr/bin/terminator", line 87, in <module>
    dbus_service = ipc.DBusService()
  File "/usr/lib/python3.8/site-packages/terminatorlib/ipc.py", line 42, in __init__
    self.prepare_attributes()
  File "/usr/lib/python3.8/site-packages/terminatorlib/ipc.py", line 55, in prepare_attributes
    raise dbus.exceptions.DBusException(
dbus.exceptions.DBusException: Couldn't get DBus name net.tenshu.Terminator25ef4b219e3b005583550f2b0f9f990c3: Name exists

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/bin/terminator", line 108, in <module>
    ipc.new_window_cmdline(optionslist)
  File "/usr/lib/python3.8/site-packages/terminatorlib/ipc.py", line 194, in _exec
    func(proxy, *args, **argd)
  File "/usr/lib/python3.8/site-packages/terminatorlib/ipc.py", line 200, in new_window_cmdline
    session.new_window_cmdline(options)
  File "/usr/lib/python3.8/site-packages/dbus/proxies.py", line 72, in __call__
    return self._proxy_method(*args, **keywords)
  File "/usr/lib/python3.8/site-packages/dbus/proxies.py", line 141, in __call__
    return self._connection.call_blocking(self._named_service,
  File "/usr/lib/python3.8/site-packages/dbus/connection.py", line 652, in call_blocking
    reply_message = self.send_message_with_reply_and_block(
dbus.exceptions.DBusException: org.freedesktop.DBus.Python.AttributeError: Traceback (most recent call last):
  File "/usr/lib/python3.8/site-packages/dbus/service.py", line 711, in _message_cb
    retval = candidate_method(self, *args, **keywords)
  File "/usr/lib/python3.8/site-packages/terminatorlib/ipc.py", line 71, in new_window_cmdline
    self.terminator.create_layout(oldopts.layout)
  File "/usr/lib/python3.8/site-packages/terminatorlib/terminator.py", line 335, in create_layout
    window.create_layout(layout[windef])
  File "/usr/lib/python3.8/site-packages/terminatorlib/window.py", line 892, in create_layout
    self.get_children()[0].create_layout(child)
  File "/usr/lib/python3.8/site-packages/terminatorlib/terminal.py", line 1666, in create_layout
    self.uuid = make_uuid(layout['uuid'])
  File "/usr/lib/python3.8/site-packages/terminatorlib/util.py", line 317, in make_uuid
    return uuid.UUID(str_uuid)
  File "/usr/lib/python3.8/uuid.py", line 166, in __init__
    hex = hex.replace('urn:', '').replace('uuid:', '')
AttributeError: 'UUID' object has no attribute 'replace'

~/.config/terminator/config

[global_config]
  borderless = True
  title_transmit_bg_color = "#888a85"
  enabled_plugins = LaunchpadBugURLHandler, LaunchpadCodeURLHandler, APTURLHandler, TerminatorThemes
[keybindings]
[profiles]
  [[default]]
    cursor_color = "#aaaaaa"
  [[Cobalt2]]
    background_color = "#132738"
    cursor_color = "#f0cc09"
    foreground_color = "#ffffff"
    palette = "#000000:#ff0000:#38de21:#ffe50a:#1460d2:#ff005d:#00bbbb:#bbbbbb:#555555:#f40e17:#3bd01d:#edc809:#5555ff:#ff55ff:#6ae3fa:#ffffff"
[layouts]
  [[default]]
    [[[child0]]]
      type = Window
      parent = ""
      order = 0
      position = 26:23
      maximised = False
      fullscreen = False
      size = 654, 453
      title = harshagoli@archlinux: ~
      last_active_term = bd9be6f8-8768-4715-9c4d-8d32bd4ead30
      last_active_window = True
    [[[terminal1]]]
      type = Terminal
      parent = child0
      order = 0
      profile = Cobalt2
      uuid = bd9be6f8-8768-4715-9c4d-8d32bd4ead30
  [[main]]
    [[[child0]]]
      type = Window
      parent = ""
      order = 0
      position = 0:0
      maximised = True
      fullscreen = False
      size = 1920, 1173
      title = harshagoli@archlinux: ~
      last_active_term = bd9be6f8-8768-4715-9c4d-8d32bd4ead30
      last_active_window = True
    [[[terminal1]]]
      type = Terminal
      parent = child0
      order = 0
      profile = Cobalt2
      uuid = bd9be6f8-8768-4715-9c4d-8d32bd4ead30
[plugins]

[arshbot]

Running with disable dbus is a workaround, however I'm not familiar with the ramifications of this option

terminator -u -l main

[mattrose]

Two things.

1. Can you try this with the changes in the latest master? I checked in a change yesterday that should be able to rescue from generic dbus exceptions.
2. How are you cloning the layout? It doesn't surprise me that dbus is complaining about duplicate UUIDs, because you're specifying the same UUID in each layout. Try removing the uuid = bd9be6f8-8768-4715-9c4d-8d32bd4ead30 from the main layout and see if you get the same error.

[mattrose]

Also, it's nice to see somebody that's taking advantage of the configuration flexibility 😄

[arshbot]

Can you try this with the changes in the latest master

Just tried, master seems to work great without needing to disable dbus 👍

How are you cloning the layout?

Initially I was cloning it by hand, but decide to regress and try to do as much as possible through the gui ( Preferences > Layout > Add ) as I realized terminator records screen size and other characteristics when adding. I was surprised to see the UUID be cloned even in this way.

Also, it's nice to see somebody that's taking advantage of the configuration flexibility smile

Yea, terminator is really powerful! One thing I've loved about it is the ability to ditch window decorations

[arshbot]

hmm, perhaps a different bug report is needed, but it seems like opening the preferences option ( via right click ) fails in master?

[mattrose]

Hmm, right-click preferences menu works for me. If you were able to clone the layout with the UUID with the add button in the layout prefs that would be a problem. I'll take a peek at that when I get the chance

[deragon]

Mmm... I have this problem with terminator 2.1.3 from the PPA today...