Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Key Binding Clearing in Preferences > Keybindings #224

Merged
merged 3 commits into from
Oct 14, 2020
Merged

Fix: Key Binding Clearing in Preferences > Keybindings #224

merged 3 commits into from
Oct 14, 2020

Commits on Sep 29, 2020

  1. Use Empty String for Cleared Accels 

    When a key binding is cleared its value is now set to "" (an empty
string) instead of `None` as before.

This change is introduced because `Gtk.accelerator_parse` does not
allow `None` to be used as a value, which in turn breaks
`on_cellrenderer_accel_edited` function in
`terminatorlib/prefseditor.py` by raising a `TypeError` every time a
new key binding is introduced. Note that this only happens if at
least one key binding has been cleared first.
    @dkmvs
    dkmvs committed Sep 29, 2020
    Configuration menu
    Copy the full SHA
    840a95e View commit details
    Browse the repository at this point in the history

  2. Add Test for Keybinding>Preferences 

    This commit adds
`test_keybinding_successfully_reassigned_after_clearing` test,
which checks that a key binding is successfully reassigned after it
has been cleared.
    @dkmvs
    dkmvs committed Sep 29, 2020
    Configuration menu
    Copy the full SHA
    03d5e20 View commit details
    Browse the repository at this point in the history

  3. Reset Key Bindings to Default in Prefseditor Test 

    This commit adds a function that resets key bindings to the default in
 `test_keybinding_edit_produce_expected_accels` test.
Note that this function needs to run at the end of every test that
modifies the key bindings as they are not automatically reset after
the test has run.
    @dkmvs
    dkmvs committed Sep 29, 2020
    Configuration menu
    Copy the full SHA
    ba5d155 View commit details
    Browse the repository at this point in the history