Remove Encoding settings (deprecated) #536
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #534
All I did was remove code. I don't expect anything breaking, since it doesn't seem to be connected to other code.
List of changes
encoding.py
was entirely deleted.preferences.glade
used to select encoding was removed, along with the signal handlers inprefseditor.py
terminal_popup_menu.py
) was removed, along with the signal handler interminal.py
encoding
andactive_encodings
were removedI don't know if there is a way to test this, since it's a feature removal. I just opened the menus and no error messages were being printed.