Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Encoding settings (deprecated) #536

Merged
merged 2 commits into from
Nov 11, 2021

Conversation

Vulcalien
Copy link
Member

Issue #534

All I did was remove code. I don't expect anything breaking, since it doesn't seem to be connected to other code.

List of changes

  • The file encoding.py was entirely deleted.
  • The GUI widget in preferences.glade used to select encoding was removed, along with the signal handlers in prefseditor.py
  • The code that generated the context menu entry (file terminal_popup_menu.py) was removed, along with the signal handler in terminal.py
  • The settings encoding and active_encodings were removed

I don't know if there is a way to test this, since it's a feature removal. I just opened the menus and no error messages were being printed.

@mattrose
Copy link
Member

✔️ Less Code
✔️ Smaller context menu

I like it!

@mattrose mattrose merged commit 2ac33bb into gnome-terminator:master Nov 11, 2021
@Vulcalien Vulcalien deleted the vte-set-encoding branch November 11, 2021 19:35
@jhalx
Copy link

jhalx commented Nov 9, 2022

How should I go about changing the terminal encoding after the option has been removed?

@jhalx
Copy link

jhalx commented Nov 9, 2022

How should I go about changing the terminal encoding after the option has been removed?

One of the biggest influencing factors of my use of the terminal is that it is very convenient to modify the terminal encoding

@jhalx
Copy link

jhalx commented Nov 9, 2022

How should I go about changing the terminal encoding after the option has been removed?

I hope to add this feature back to the built-in plugin and set it to be turned off by default. Although most people don't need this feature, it is indispensable.

@Vulcalien
Copy link
Member Author

The reason we removed it was that vte, the terminal GTK component, deprecated it. It would be up to them to add it back, and then we could revert this change as well.

It is very unfortunate, but maybe a command like luit could help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants