Do not remove focus from the last_active_window #726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This caused all the new windows to be unfocused, forcing the user to manually focus one. The 'last_active_window' feature might be broken anyway.
|
Thanks for doing this. I haven't actually tested it I just merged it from my phone but I looked over the change and it looks good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This caused all the new windows to be unfocused, forcing the user to manually focus one.
From the docs:
On my machine, the last_active_window feature seems to be broken.
I've spent some time trying to figure out why, but found nothing.
Most of the
layout_donefunction appears to do nothing useful, but that might be different on other Desktop Environments.It's an old problem, with commits from 10 years ago trying to fix it. And it's a mess.